Fix broken browser integration since #6899 #7030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a regression from #6899. Before #1770, entry UUIDs are simply random 16-byte strings. On the other hand, since PR #6899, only RFC4122 UUIDs with a valid version are accepted. As a result, browser actions passing a UUID (ex: get_totp) are rejected with "No valid UUID provided" for older entries.
|
Good catch! |
varjolintu
approved these changes
Oct 8, 2021
|
Hmm, it seems all links on https://ci.keepassxc.org/ are now "404 Not Found" 🤔 |
|
I poked @phoerious about it, he should be able to get it back soon. |
|
Forgot to update the ingress definition after an upgrade. It's back up now. |
|
Thanks! Turns out I forgot that my custom build script comments out tests. Should be fixed now. |
phoerious
reviewed
Oct 9, 2021
Codecov Report
@@ Coverage Diff @@
## develop #7030 +/- ##
========================================
Coverage 63.68% 63.68%
========================================
Files 330 330
Lines 41601 41601
========================================
Hits 26491 26491
Misses 15110 15110
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a regression from
#6899.
Before #1770, entry
UUIDs are simply random 16-byte strings. On the other hand, since
PR #6899, only RFC4122 UUIDs with a valid version are accepted. As a
result, browser actions passing a UUID (ex: get_totp) are rejected with
"No valid UUID provided" for older entries.
Screenshots
N/A
Testing strategy
Manual using old entries with TOTP set up
Type of change