Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CLI man page and change both man pages #4189

Merged
merged 2 commits into from
Jan 25, 2020
Merged

Fix CLI man page and change both man pages #4189

merged 2 commits into from
Jan 25, 2020

Conversation

sorairolake
Copy link
Contributor

Type of change

  • ✅ Documentation (non-code change)

Description and Context

  • Fix lacking commas between short and long option names (e.g. -l and --lower) in the generate options section of CLI man page, and fix a typo in groff command.
  • Changed command and option names in man page to bold. Because it's easier to understand than if it's not bold.

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]

@sorairolake
Fix CLI man page
316e40a 
- Fix lacking commas in the generate options section
- Fix a typo in groff command
@sorairolake
Change command and option names to bold in man pages
6765c97
@droidmonkey droidmonkey requested a review from louib January 16, 2020 12:14
@droidmonkey droidmonkey added this to the v2.6.0 milestone Jan 16, 2020
@sorairolake
Copy link
Contributor Author

share/docs/man/keepassxc-cli.1 seems to be updated in #4231, but should I do something to this to match the changes in 6765c97?

@louib
Copy link
Member

louib commented Jan 25, 2020

@droidmonkey can we get this one merged? This way we can rebase and use the new man page styling in the currently opened CLI PRs.

@droidmonkey
Copy link
Member

Sure thing

@droidmonkey droidmonkey merged commit 8bac8a7 into keepassxreboot:develop Jan 25, 2020
@sorairolake
Copy link
Contributor Author

Thank you😊

@sorairolake sorairolake deleted the feature/fix-cli-man-page branch March 21, 2020 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louib louib louib approved these changes

Assignees
No one assigned
Labels
documentation 📑 feature: CLI
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sorairolake @louib @droidmonkey