Copy paste bug in BaseStyle.cpp

[qarmin]

Probably second occurrence of colors[S_text] should be removed

keepassxc/src/gui/styles/base/BaseStyle.cpp

Lines 398 to 400 in 26ea274

	colors[S_text] = pal.color(QPalette::Text);
	colors[S_text] = pal.color(QPalette::WindowText);
	colors[S_windowText] = pal.color(QPalette::WindowText);

[droidmonkey]

Phantom bug. https://github.com/randrew/phantomstyle

[randrew]

I've fixed this upstream at randrew/phantomstyle@22c58ee

[randrew]

You should be able to apply this fix without any visual changes occurring in your UI.

I think these are the palette values you're using:

keepassxc/src/gui/styles/light/LightStyle.cpp

Lines 33 to 39 in 5c69875

	palette.setColor(QPalette::Active, QPalette::WindowText, QStringLiteral("#1D1D20"));
	palette.setColor(QPalette::Inactive, QPalette::WindowText, QStringLiteral("#252528"));
	palette.setColor(QPalette::Disabled, QPalette::WindowText, QStringLiteral("#8C8C92"));
	palette.setColor(QPalette::Active, QPalette::Text, QStringLiteral("#1D1D20"));
	palette.setColor(QPalette::Inactive, QPalette::Text, QStringLiteral("#252528"));
	palette.setColor(QPalette::Disabled, QPalette::Text, QStringLiteral("#8C8C92"));

keepassxc/src/gui/styles/dark/DarkStyle.cpp

Lines 32 to 38 in 5c69875

	palette.setColor(QPalette::Active, QPalette::WindowText, QStringLiteral("#CACBCE"));
	palette.setColor(QPalette::Inactive, QPalette::WindowText, QStringLiteral("#C8C8C6"));
	palette.setColor(QPalette::Disabled, QPalette::WindowText, QStringLiteral("#707070"));
	palette.setColor(QPalette::Active, QPalette::Text, QStringLiteral("#CACBCE"));
	palette.setColor(QPalette::Inactive, QPalette::Text, QStringLiteral("#C8C8C6"));
	palette.setColor(QPalette::Disabled, QPalette::Text, QStringLiteral("#707070"));

For these palettes, and my own test palettes, and all of the palettes I've seen in the wild, QPalette::Text and QPalette::WindowText ColorRoles use the same color value.

Thanks for finding this bug.

---

Unrelated aside: I saw that you're using QStringLiteral to populate the color values. QStringLiteral tends to generate a fair bit of binary bloat, at least with the compilers I've used. You might instead want to consider using integer literals, if that sort of thing is a priority in your project.

[phoerious]

Text and WindowText are the same, yes.

It's true that QStringLiteral is not optimal for strings which are not necessarily unique, perhaps we could be using QLatin1String or so instead. The reason why these are not numerical colour values is because hex codes are easier to copy-paste in and from graphics applications, where we can tweak and optimise them.

[droidmonkey]

BTW, @randrew, we just tried Qt 5.15 and it completely fails to apply the palette. I believe this to be a Qt bug, rather major one.

[randrew]

@phoerious you can use hex literals, which is what those strings are emulating -- just replace QStringLiteral("#1D1D20") with 0x1D1D20.

@droidmonkey I don't have access to a Qt 5.15 installation right now. Are you saying you tried the KeePassXC code and the palettes didn't apply, or you tried the PhantomStyle code (probably the 'funhouse' project) and it didn't work? (Or both?)

[phoerious]

you can use hex literals, which is what those strings are emulating -- just replace QStringLiteral("#1D1D20") with 0x1D1D20.

Good point. We should do that.

(Or both?)

That.