Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve application icons [$50] #475

Closed
lifepillar opened this issue Apr 6, 2017 · 25 comments · Fixed by #4066
Closed

Improve application icons [$50] #475

lifepillar opened this issue Apr 6, 2017 · 25 comments · Fixed by #4066
Assignees
Milestone

Comments

@lifepillar
Copy link

lifepillar commented Apr 6, 2017

I apologize for the somewhat light-minded request, but… no plan to switch to vector icons? On macOS, at least, they do not look so gorgeous… (the app icon is beautiful, though).

I know that resources are tight and there are other priorities. A good-looking UI, however, may attract a wider public to KeePassXC, making it eventually more popular.

@weslly
Copy link
Contributor

weslly commented Apr 6, 2017

I agree. IMHO the current icon theme looks bad and outdated, I would love to see something more modern, like the elementary icon set maybe. Nuvola is ~12 years old already.

@droidmonkey droidmonkey added this to the v2.3.0 milestone Apr 8, 2017
@droidmonkey
Copy link
Member

I'm going to table this until 2.3.0, but I am open to seeing some suggestions and sample icon sets posted here. I totally agree the current set of icons is.... dated

@droidmonkey droidmonkey changed the title [Feature request] Improve icons Improve application icons Apr 8, 2017
@lifepillar
Copy link
Author

Maybe, something among these sets: https://tagliala.github.io/vectoriconsroundup/.

@lifepillar
Copy link
Author

Here, there are several open source icon sets: https://icons8.com/welovesvg.

@phoerious
Copy link
Member

phoerious commented Apr 9, 2017

The icons we are currently using are from KeePass. I don't really like the myself. Neither are they especially beautiful nor do we have any high-res versions of them. 22x22px is all we have. We need to replace them at some point.

@gagarine
Copy link

gagarine commented Aug 12, 2017

A related note about the "add a new entry". This icon is not understandable (at least for my mum). It should have a + I guess so it' easy to understand it for "add".

screen shot 2017-08-12 at 15 07 17

This is specially perturbing because the "New database" icon do have a +.
screen shot 2017-08-12 at 15 11 13

Anyway, I think the "new database" should not be in the toolbar to avoid confusion.

@gagarine
Copy link

Why not taking https://github.com/mstarke/MacPass icon?

screen shot 2017-08-15 at 22 00 17

@CoalaJoe
Copy link

How about Material Icons?

@edubxb
Copy link

edubxb commented Aug 23, 2017

As a GNOME user, I really appreciate the integration with the look and feel of the desktop, so the application should use the icons provided by the theme I'm using when possible.

@phoerious
Copy link
Member

That won't change. We are only talking about fallback icons.

@cryptomilk
Copy link
Contributor

On HiDPI screens the icons look pretty horrible. It would be really great to have a new set with higher resolution icons.

@mueller-ma
Copy link

mueller-ma commented Feb 28, 2018

For openHAB I improved a script (https://github.com/mueller-ma/openhab-mdi) that generates icons from https://www.materialdesignicons.com/ (Community driven material design icon). The script renames and changes the color of the source icons.
If you want to use material icons, I can help you with that.

@ArchangeGabriel
Copy link

@cryptomilk HiDPI is #548, but #756 should solve it. BTW, #756 is what you are looking for @edubxb.

phoerious pushed a commit to wolframroesler/keepassxc that referenced this issue Jan 11, 2020
Use the following to run KeePassXC with the icons from the
source code, ignoring the operating system's Qt icon theme:

```
KEEPASSXC_IGNORE_ICON_THEME=1 keepassxc
```

The patch further adds a script `makeicons.sh` that re-creates KeePassXC
icons from the Material Design icon set and can be used for easily
updating icons in the future. Instructions are in the script.

Fixes keepassxreboot#475
phoerious pushed a commit to wolframroesler/keepassxc that referenced this issue Jan 11, 2020
for the "Toggle Window" menu item. It matches the other
(Material Design) icons much better than the colored
icon.

Fixes keepassxreboot#475
phoerious pushed a commit to wolframroesler/keepassxc that referenced this issue Jan 11, 2020
... not only on Linux, in order to prevent icons from being fuzzy.

Fixes keepassxreboot#475
phoerious pushed a commit to wolframroesler/keepassxc that referenced this issue Jan 11, 2020
It's used extremely rarely, having it in such a prominent position
in the tool bar isn't justified. Also, with the Material Design
icons, its tool bar icon can easily be confused with "create new
entry".

Fixes keepassxreboot#475
@wolframroesler
Copy link
Contributor

One more thing. Here's how it currently looks with the Material Design icons:

Screenshot from 2020-01-11 17-45-50

... at least that how it looks when system theme icons are disabled (for which I temporarily introduced an env variable that I can set during development). The regular version (as of #756), however, allows the system theme to override icons, which doesn't look too pretty:

Screenshot from 2020-01-11 18-03-38

How about introducing a check box in the settings dialog that configures whether the system icon theme is to be used or not?

phoerious pushed a commit to wolframroesler/keepassxc that referenced this issue Jan 11, 2020
Use the following to run KeePassXC with the icons from the
source code, ignoring the operating system's Qt icon theme:

```
KEEPASSXC_IGNORE_ICON_THEME=1 keepassxc
```

The patch further adds a script `makeicons.sh` that re-creates KeePassXC
icons from the Material Design icon set and can be used for easily
updating icons in the future. Instructions are in the script.

Fixes keepassxreboot#475
phoerious pushed a commit to wolframroesler/keepassxc that referenced this issue Jan 11, 2020
for the "Toggle Window" menu item. It matches the other
(Material Design) icons much better than the colored
icon.

Fixes keepassxreboot#475
phoerious pushed a commit to wolframroesler/keepassxc that referenced this issue Jan 11, 2020
... not only on Linux, in order to prevent icons from being fuzzy.

Fixes keepassxreboot#475
phoerious pushed a commit to wolframroesler/keepassxc that referenced this issue Jan 11, 2020
It's used extremely rarely, having it in such a prominent position
in the tool bar isn't justified. Also, with the Material Design
icons, its tool bar icon can easily be confused with "create new
entry".

Fixes keepassxreboot#475
@droidmonkey
Copy link
Member

I would not allow any system icons at this point

phoerious pushed a commit to wolframroesler/keepassxc that referenced this issue Jan 11, 2020
Use the following to run KeePassXC with the icons from the
source code, ignoring the operating system's Qt icon theme:

```
KEEPASSXC_IGNORE_ICON_THEME=1 keepassxc
```

The patch further adds a script `makeicons.sh` that re-creates KeePassXC
icons from the Material Design icon set and can be used for easily
updating icons in the future. Instructions are in the script.

Fixes keepassxreboot#475
phoerious pushed a commit to wolframroesler/keepassxc that referenced this issue Jan 11, 2020
for the "Toggle Window" menu item. It matches the other
(Material Design) icons much better than the colored
icon.

Fixes keepassxreboot#475
phoerious pushed a commit to wolframroesler/keepassxc that referenced this issue Jan 11, 2020
... not only on Linux, in order to prevent icons from being fuzzy.

Fixes keepassxreboot#475
phoerious pushed a commit to wolframroesler/keepassxc that referenced this issue Jan 11, 2020
It's used extremely rarely, having it in such a prominent position
in the tool bar isn't justified. Also, with the Material Design
icons, its tool bar icon can easily be confused with "create new
entry".

Fixes keepassxreboot#475
@wolframroesler
Copy link
Contributor

I would not allow any system icons at this point

You mean, undo #756, and behave as if KEEPASSXC_IGNORE_ICON_THEME (the env var I introduced to disable the system icon theme, cf. #475 (comment)) was set permanently?

@droidmonkey
Copy link
Member

Yes precisely. Especially if we package the icons with the executable and eliminate all the filepath nonsense in the code. You either have material icons or you don't. There is no sense in a hybrid icon look.

phoerious pushed a commit that referenced this issue Jan 11, 2020
Use the following to run KeePassXC with the icons from the
source code, ignoring the operating system's Qt icon theme:

```
KEEPASSXC_IGNORE_ICON_THEME=1 keepassxc
```

The patch further adds a script `makeicons.sh` that re-creates KeePassXC
icons from the Material Design icon set and can be used for easily
updating icons in the future. Instructions are in the script.

Fixes #475
phoerious pushed a commit that referenced this issue Jan 11, 2020
for the "Toggle Window" menu item. It matches the other
(Material Design) icons much better than the colored
icon.

Fixes #475
phoerious pushed a commit that referenced this issue Jan 11, 2020
... not only on Linux, in order to prevent icons from being fuzzy.

Fixes #475
phoerious pushed a commit that referenced this issue Jan 11, 2020
It's used extremely rarely, having it in such a prominent position
in the tool bar isn't justified. Also, with the Material Design
icons, its tool bar icon can easily be confused with "create new
entry".

Fixes #475
wolframroesler added a commit to wolframroesler/keepassxc that referenced this issue Jan 11, 2020
With the Material Design icons, any other icons brought in through
the system icon theme will look inconsistent.

Also remove the KEEPASSXC_IGNORE_ICON_THEME environment variable
(which was introduced during development of the new icons to
disable the system icon theme and is thus no longer needed).

Fixes keepassxreboot#475
wolframroesler added a commit to wolframroesler/keepassxc that referenced this issue Jan 11, 2020
This is an experimental commit that makes KeePassXC use fixed-size
PNG icons instead of relying on Qt's SVG scaling. Note that the
result is not completely satisfactory (and may be system-dependent).

It comes with a shell script (utils/makepng.sh) that converts the
SVG files to PNG. The script contains three implementations of the
SVG->PNG conversion routine, two with ImageMagick and one with
Inkscape. Instructions for use are in the script's header comment.

Fixes keepassxreboot#475 (after some more work).
wolframroesler added a commit to wolframroesler/keepassxc that referenced this issue Jan 11, 2020
This is an experimental commit that makes KeePassXC use fixed-size
PNG icons instead of relying on Qt's SVG scaling. Note that the
result is not completely satisfactory (and may be system-dependent).

It comes with a shell script (utils/makepng.sh) that converts the
SVG files to PNG. The script contains three implementations of the
SVG->PNG conversion routine, two with ImageMagick and one with
Inkscape. Instructions for use are in the script's header comment.

Fixes keepassxreboot#475/keepassxreboot#4066 (after some more work).
droidmonkey pushed a commit to wolframroesler/keepassxc that referenced this issue Jan 27, 2020
With the Material Design icons, any other icons brought in through
the system icon theme will look inconsistent.

Also remove the KEEPASSXC_IGNORE_ICON_THEME environment variable
(which was introduced during development of the new icons to
disable the system icon theme and is thus no longer needed).

Fixes keepassxreboot#475
droidmonkey pushed a commit to wolframroesler/keepassxc that referenced this issue Jan 28, 2020
With the Material Design icons, any other icons brought in through
the system icon theme will look inconsistent.

Also remove the KEEPASSXC_IGNORE_ICON_THEME environment variable
(which was introduced during development of the new icons to
disable the system icon theme and is thus no longer needed).

Fixes keepassxreboot#475
droidmonkey pushed a commit that referenced this issue Jan 30, 2020
With the Material Design icons, any other icons brought in through
the system icon theme will look inconsistent.

Also remove the KEEPASSXC_IGNORE_ICON_THEME environment variable
(which was introduced during development of the new icons to
disable the system icon theme and is thus no longer needed).

Fixes #475
wolframroesler added a commit to wolframroesler/keepassxc that referenced this issue Jan 30, 2020
With the Material Design icons, any other icons brought in through
the system icon theme will look inconsistent.

Also remove the KEEPASSXC_IGNORE_ICON_THEME environment variable
(which was introduced during development of the new icons to
disable the system icon theme and is thus no longer needed).

Fixes keepassxreboot#475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.