Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

dev: split integration tests into multiple files 🔨 #836

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

MdTeach
Copy link
Contributor

@MdTeach MdTeach commented Jul 9, 2023

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • Testing

What is the current behavior?

Resolves: #824

What is the new behavior?

  • Splits the integration tests within multiple files

Does this introduce a breaking change?

No

Other information

Initially while defining the test case each test case defined with describeDevMadara("test case", ()=>{....}) would run the new instance of the server. With this, each test file would run a new instance of Madara.

To mitigate this server is initiated before running any test cases. In some cases, if the test suite needs a new instance of the server then it can be achieved with describeDevMadara("test case", ()=>{....}, { runNewNode: true })

@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (67c992d) 41.72% compared to head (5361151) 41.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #836   +/-   ##
=======================================
  Coverage   41.72%   41.72%           
=======================================
  Files          86       86           
  Lines       10686    10686           
  Branches    10686    10686           
=======================================
  Hits         4459     4459           
  Misses       5662     5662           
  Partials      565      565           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MdTeach MdTeach marked this pull request as ready for review July 9, 2023 17:58
Copy link
Contributor

@AbdelStark AbdelStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AbdelStark AbdelStark merged commit 5a49478 into keep-starknet-strange:main Jul 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev: split integration tests into multiple files 🔨
2 participants