Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

Adding pallet test for declare transaction v0, fixes #1603 #1605

Merged

Conversation

elielnfinic
Copy link
Contributor

This PR fixes issue #1603, adding Declare Transaction V0 to the test as all the other tests were using V1.

Pull Request type

Enhancement

Please add the labels corresponding to the type of changes your PR introduces:

  • Feature
  • Testing

What is the current behavior?

All the transaction tests in `` are Declaration Transaction V1.

Resolves: missing V0 tests.

What is the new behavior?

We have a possibility to check V0 transactions.

Does this introduce a breaking change?

No.

Other information

NA

@elielnfinic elielnfinic marked this pull request as ready for review May 16, 2024 04:44
CHANGELOG.md Outdated Show resolved Hide resolved
crates/pallets/starknet/src/tests/declare_tx.rs Outdated Show resolved Hide resolved
@tdelabro tdelabro merged commit 9ff0b4a into keep-starknet-strange:main May 17, 2024
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants