Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

dev: use with_capacity #1535

Merged
merged 2 commits into from
Mar 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Next release

- dev: change `Vec::new` to `Vec::with_capacity` where possible.
- chore(rpc): clean trace api
- feat(rpc): added state diff real value in trace api
- chore: update cairo-vm commit and update gas per op
Expand Down
2 changes: 1 addition & 1 deletion crates/primitives/snos-output/src/codec.rs
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ impl<T: SnosCodec> SnosCodec for Vec<T> {

fn decode(input: &mut FeltReader) -> Result<Self, FeltReaderError> {
let mut segment_reader = FeltReader::new(input.read_segment()?);
let mut elements: Vec<T> = Vec::new();
let mut elements: Vec<T> = Vec::with_capacity(segment_reader.remaining_len());
while segment_reader.remaining_len() > 0 {
elements.push(T::decode(&mut segment_reader)?);
}
Expand Down
3 changes: 2 additions & 1 deletion starknet-e2e-test/src/starknet_sovereign.rs
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,8 @@ impl StarknetSovereign {
}

pub async fn message_to_l1_exists(&self, message: &MessageL2ToL1) -> bool {
let mut payload: Vec<u8> = Vec::new();
let message_felt_size = message.size_in_felts();
let mut payload: Vec<u8> = Vec::with_capacity(32 * message_felt_size);
message.clone().into_encoded_vec().into_iter().for_each(|felt| payload.append(&mut felt.bytes().to_vec()));

let msg_hash = keccak256(payload);
Expand Down
4 changes: 2 additions & 2 deletions starknet-rpc-test/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ impl MadaraClient {
&mut self,
transactions: Vec<Transaction<'_>>,
) -> anyhow::Result<Vec<Result<TransactionResult, SendTransactionError>>> {
let mut results = Vec::new();
let mut results = Vec::with_capacity(transactions.len());
for tx in transactions {
let result = tx.send().await;
results.push(result);
Expand All @@ -184,7 +184,7 @@ impl MadaraClient {
&mut self,
transactions: Vec<Transaction<'_>>,
) -> Vec<Result<TransactionResult, SendTransactionError>> {
let mut results = Vec::new();
let mut results = Vec::with_capacity(transactions.len());
for tx in transactions {
let result = tx.send().await;
results.push(result);
Expand Down
Loading