This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
Bug: Fix missing main_scope field #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
tdelabro
approved these changes
Apr 30, 2024
|
@fishseabowl rpc-tests are failing |
@tdelabro Thank you for your review. I've opened issue #1585 to address the failed RPC test. The issue may stem from an incorrect return value from rpc.get_class_at() due to recent updates in the codebase. |
tdelabro
suggested changes
May 7, 2024
tdelabro
approved these changes
May 13, 2024
Gerson2102
pushed a commit
to Gerson2102/madara
that referenced
this pull request
May 13, 2024
Authored-by: fishseabowl <xuefei.han@domichain.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
What is the current behavior?
Resolves: #1469
What is the new behavior?
Add a wrapper struct around the LegacyProgram and implement deserialization for it to fix the missing main_scope field
Does this introduce a breaking change?
No
Other information