This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
Testcases related to starkgate bridging #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvolveArt
reviewed
Mar 15, 2024
|
@apoorvsadana @tdelabro not sure why some of the test cases are failing because I didn't make any modifications in them as such. Also, right now in cargo.toml I've updated the zaun to point to my repo but I think we want to get that PR merged first and then update the version here. Please re review this PR as well and here is the link to zaun PR. |
* fix bridging test cases * fix cargo import * fix non bridge case
apoorvsadana
reviewed
Apr 3, 2024
apoorvsadana
reviewed
Apr 3, 2024
1935abc to
e113c3f
Compare
apoorvsadana
approved these changes
Apr 8, 2024
EvolveArt
approved these changes
Apr 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds testcases for both eth and erc20 token bridging btw eth and madara
Pull Request type
Does this introduce a breaking change?
No
Other information
Dependent on Zaun PR#9