This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
add: from_address in l1 message calldata #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoorvsadana
approved these changes
Feb 17, 2024
tdelabro
suggested changes
Feb 19, 2024
tdelabro
approved these changes
Feb 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cairo contracts try to fetch from_address from the 0th index of call data, this was noticed while trying to integrate starkgate and was later confirmed on
Starknet Cairo Core Stars - PharaohsgroupPlease add the labels corresponding to the type of changes your PR introduces:
What is the current behavior?
Currently the calldata directly parsed from the event in L1 without any modification.
Resolves: #NA
What is the new behavior?
Adds from_data at 0th index of calldata