-
Notifications
You must be signed in to change notification settings - Fork 292
dev: check that class exist before using it in BuildGenesisConfig #1389
dev: check that class exist before using it in BuildGenesisConfig #1389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
@kfastov can you add a line in the CHANGELOG.md file please? So the CI can run ;) |
@tdelabro Yes sure |
@kfastov just fix the linters and we will merge that asap |
Oh I see there is a linter issue in |
a9aa0ca
to
e1348db
Compare
@kfastov Good job! I wait for the CI to pass and I will merge. Thanks a lot |
@kfastov tests are failing |
@tdelabro I will check tests tomorrow and finish this PR finally. Also, I have done what you said (solution 2), but not yet finished the tests (finding a way to instantiate contract classes in test). |
Head branch was pushed to by a user without write access
There is probably an issue with |
@kfastov you also have to fix a lil discrepancy between the error message expect and the actual one in rpc-tests |
@kfastov thanks a lot for staying involved in this one although all the rebase conflicts |
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
What is the current behavior?
Genesis config builder does not check the existence of contract classes
Resolves: #1345
What is the new behavior?
contracts
orsierra_class_hash_to_casm_class_hash
is not defined incontract_classes
.Does this introduce a breaking change?
No