Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

Improve stability with avail DA #1257

Merged
merged 20 commits into from
Nov 9, 2023
Merged

Improve stability with avail DA #1257

merged 20 commits into from
Nov 9, 2023

Conversation

vibhurajeev
Copy link
Contributor

@vibhurajeev vibhurajeev commented Nov 8, 2023 •
edited
Loading

Pull Request type

  • Refactoring (no functional changes, no API changes)

What is the current behavior?

The current behaviour does not have ws restart implemented and da worker waits for transaction finalisation.

Resolves: #NA

What is the new behavior?

  • The new behaviour creates a new ws connection on connection closed.
  • The da worker now fires the da transaction and does not wait for finalisation.

Does this introduce a breaking change?

No

Other information

Leouarz and others added 19 commits November 3, 2023 08:48
@Leouarz
fix base-path for da, update avail deps
5c97c00
@vibhurajeev
fix(commands-run): reverted base_path change
b358765
@vibhurajeev
Merge pull request #1 from vibhurajeev/vr/update-avail-da-versions
502edda 
Vr/update avail da versions
@vibhurajeev
Merge branch 'main' into main
3d92000
@vibhurajeev
Update CHANGELOG.md
1fc7e0d
@vibhurajeev
Merge branch 'main' into main
f55a67f
@vibhurajeev
fix(avail): fmt
7a446b3
@vibhurajeev
Merge branch 'main' of https://github.com/vibhurajeev/madara
1ab2c21
@EvolveArt
Merge branch 'main' into main
2c16f77
@EvolveArt
Merge branch 'main' into main
907e1b6
@lana-shanghai
Merge branch 'main' into main
5846e00
@vibhurajeev
chore(da-avail): Added restart ws client
c61e872
@vibhurajeev
Merge branch 'main' into vr/fix-stability
09ed559
@vibhurajeev
Update CHANGELOG.md
c903689
@vibhurajeev
Merge branch 'vr/fix-stability' of https://github.com/vibhurajeev/madara
1ee8499 
 into vr/fix-stability
@vibhurajeev
fix(da-avail): cleanup
266b0c7
@vibhurajeev
fix(changelog): updated missing details
8a332ec
@vibhurajeev
fix(changelog): prettier fix
c64103a
@vibhurajeev
fix(da-avail): cleanup
e46abc6
EvolveArt
EvolveArt approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@EvolveArt EvolveArt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol changes otherwise lgtm

crates/client/data-availability/src/avail/mod.rs Outdated Show resolved Hide resolved
crates/client/data-availability/src/avail/mod.rs Outdated Show resolved Hide resolved
crates/client/data-availability/src/avail/mod.rs Show resolved Hide resolved
crates/client/data-availability/src/avail/mod.rs Show resolved Hide resolved
crates/client/data-availability/src/avail/mod.rs Show resolved Hide resolved
crates/client/data-availability/src/avail/mod.rs Outdated Show resolved Hide resolved
@EvolveArt EvolveArt merged commit 43b2353 into keep-starknet-strange:main Nov 9, 2023
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EvolveArt EvolveArt EvolveArt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vibhurajeev @EvolveArt @Leouarz @lana-shanghai