chore: split starknetRPC in two traits to follow openRPC spec definit…

…ion (#1274)

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## Next release
 
+- chore: split StarknetRpcApi trait in two, like in openRPC specs
 - refacto: move starknet runtime api in it's own crate
 - chore: update README.md and getting-started.md
 - chore: remove crates that have been copy-pasted from plkdtSDK

crates/client/rpc-core/src/lib.rs

@@ -27,9 +27,34 @@ use starknet_core::types::{
 #[derive(Serialize, Deserialize)]
 pub struct Felt(#[serde_as(as = "UfeHex")] pub FieldElement);
 
+/// Starknet write rpc interface.
+#[rpc(server, namespace = "starknet")]
+pub trait StarknetWriteRpcApi {
+    /// Submit a new transaction to be added to the chain
+    #[method(name = "addInvokeTransaction")]
+    async fn add_invoke_transaction(
+        &self,
+        invoke_transaction: BroadcastedInvokeTransaction,
+    ) -> RpcResult<InvokeTransactionResult>;
+
+    /// Submit a new class declaration transaction
+    #[method(name = "addDeployAccountTransaction")]
+    async fn add_deploy_account_transaction(
+        &self,
+        deploy_account_transaction: BroadcastedDeployAccountTransaction,
+    ) -> RpcResult<DeployAccountTransactionResult>;
+
+    /// Submit a new deploy account transaction
+    #[method(name = "addDeclareTransaction")]
+    async fn add_declare_transaction(
+        &self,
+        declare_transaction: BroadcastedDeclareTransaction,
+    ) -> RpcResult<DeclareTransactionResult>;
+}
+
 /// Starknet rpc interface.
 #[rpc(server, namespace = "starknet")]
-pub trait StarknetRpcApi {
+pub trait StarknetReadRpcApi {
     /// Get the most recent accepted block number
     #[method(name = "blockNumber")]
     fn block_number(&self) -> RpcResult<u64>;
@@ -83,20 +108,6 @@ pub trait StarknetRpcApi {
     #[method(name = "chainId")]
     fn chain_id(&self) -> RpcResult<Felt>;
 
-    /// Add an Invoke Transaction to invoke a contract function
-    #[method(name = "addInvokeTransaction")]
-    async fn add_invoke_transaction(
-        &self,
-        invoke_transaction: BroadcastedInvokeTransaction,
-    ) -> RpcResult<InvokeTransactionResult>;
-
-    /// Add a Deploy Account Transaction
-    #[method(name = "addDeployAccountTransaction")]
-    async fn add_deploy_account_transaction(
-        &self,
-        deploy_account_transaction: BroadcastedDeployAccountTransaction,
-    ) -> RpcResult<DeployAccountTransactionResult>;
-
     /// Estimate the fee associated with transaction
     #[method(name = "estimateFee")]
     async fn estimate_fee(
@@ -121,13 +132,6 @@ pub trait StarknetRpcApi {
     #[method(name = "getEvents")]
     async fn get_events(&self, filter: EventFilterWithPage) -> RpcResult<EventsPage>;
 
-    /// Submit a new transaction to be added to the chain
-    #[method(name = "addDeclareTransaction")]
-    async fn add_declare_transaction(
-        &self,
-        declare_transaction: BroadcastedDeclareTransaction,
-    ) -> RpcResult<DeclareTransactionResult>;
-
     /// Returns the information about a transaction by transaction hash.
     #[method(name = "getTransactionByHash")]
     fn get_transaction_by_hash(&self, transaction_hash: FieldElement) -> RpcResult<Transaction>;

crates/client/rpc/Cargo.toml

@@ -42,6 +42,7 @@ starknet-core = { workspace = true }
 starknet-ff = { workspace = true }
 starknet_api = { workspace = true, default-features = false }
 # Others
+anyhow = { workspace = true }
 hex = { workspace = true, default-features = true }
 jsonrpsee = { workspace = true, default-features = true, features = [
   "server",