Added approveAndCall to TBTC token
#5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
approveAndCall is not a part of ERC20 - it was specified in ERC827 and slightly diverged for some implementations. This one is identical to approveAndCall behavior of KEEP token. approveAndCall executes receiveApproval function on the spender as specified in IReceiveApproval interface. Approves spender to withdraw from the caller multiple times, up to the value amount. If this function is called again, it overwrites the current allowance with the provided value. Reverts if the approval operation reverted or if receiveApproval call on the spender reverted.
3ecf33c to
4799cdf
Compare
dimpar
reviewed
Jun 16, 2021
|
|
||
| pragma solidity <0.9.0; | ||
|
|
||
| import "@openzeppelin/contracts/token/ERC20/SafeERC20.sol"; |
There was a problem hiding this comment.
I think we can remove this import
| @@ -5,6 +5,37 @@ pragma solidity <0.9.0; | |||
| import "./ERC20WithPermit.sol"; | |||
| import "./MisfundRecovery.sol"; | |||
|
|
|||
| interface IReceiveApproval { | |||
There was a problem hiding this comment.
In TBTC v1 this interface is named ITokenRecipient. Was there a reason why we don't want to name it the same?
There was a problem hiding this comment.
In retrospect, I think ITokenRecipient is too broad. It is about a specific way of receiving approval and maybe receiving tokens if the implementation decides for that.
There was a problem hiding this comment.
Sure, I'm okay with both, but what I liked about ITokenRecipient is that it tells me right away in its name that this contract will receive tokens. IReceiveApproval(spender).receiveApproval also looks a bit redundant.
dimpar
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #4
approveAndCallis not a part of ERC20 - it was specified in ERC827 andslightly diverged for some implementations. This one is identical to
approveAndCallbehavior of KEEP token.approveAndCallexecutesreceiveApprovalfunction on the spender asspecified in
IReceiveApprovalinterface. Approves spender to withdrawfrom the caller multiple times, up to the value amount. If this function
is called again, it overwrites the current allowance with the provided
value. Reverts if the approval operation reverted or if
receiveApprovalcall on the spender reverted.