Relay request timeout #897

dimpar · 2019-07-02T13:31:54Z

Refs: #884

In this PR we need to block upcoming requests from processing if there is one in progress. After a node generates a relay entry, then it can again start processing a new request. These are the rules when we block a new relay request from processing:

relaySigningInProgess  | block.number > relayEntryTimeout | blocking a new relay request?
true                   |           true                   | no
true                   |           false                  | yes
false                  |           true                   | no
false                  |           false                  | no

First step as part of the refactoring this contract as immutable back-end for the random beacon. Removing getters for the constants since these are now auto-generated from public variables.

…end contract

Backend contract should not track beacon entries and only needs to hold the last entry used as a selection seed for the next group selection run.

This is useful in case of using specific stub contracts in tests.

Use 'before' instead of 'beforeEach' where possible.

This contract is not used by the Keep client, CLI for relay requests has been implemented with truffle scripts and located in `contract/scripts`.

- Set relayRequestTimeout to 17 - Modified sign(..) function by adding require(..) to handle timeout - Added tests

dimpar · 2019-07-02T13:33:42Z

TODO: Need to merge master after upgradable contract components is merged.
This is the actual change for the relay request timeout minus package.json

dimpar · 2019-07-02T13:37:40Z

Testing for `relayRequestTimeout` blocks calculation: 47579 - 47562 = 17

New relay entry requested [&{RequestID:+2 Payment:+0 PreviousEntry:+10920102476789591414949377782104707130412218726336356788412941355500907533021 Seed:+53067088278316309045121968048462724729152109215234493179134844471987707841858 GroupPublicKey:[148 201 102 80 168 175 134 22 57 88 174 102 140 6 86 157 161 253 198 211 221 66 2 185 54 173 121 213 147 68 47 34 3 106 162 84 138 240 215 67 22 146 199 110 198 201 30 30 165 163 237 77 177 130 240 136 9 94 34 95 134 202 253 107] BlockNumber:47562}]
[member:2] Waiting for block 47562 to start execution...
[member:2, state:*entry.signatureShareState] Transitioning to a new state at block [47562]...
[member:4] Waiting for block 47562 to start execution...
[...]

[member:2, state:*entry.signatureCompleteState] Transitioned to new state
[member:2, state:*entry.entrySubmissionState] Transitioning to a new state at block [47566]...
error creating threshold signature for request [2]: [failed to initiate new state [blocking member index [2]]]
[member:1, state:*entry.signatureCompleteState] Transitioned to new state
[member:3, state:*entry.signatureCompleteState] Transitioned to new state
[member:3, state:*entry.entrySubmissionState] Transitioning to a new state at block [47566]...
[member:1, state:*entry.entrySubmissionState] Transitioning to a new state at block [47566]...
error creating threshold signature for request [2]: [failed to initiate new state [blocking member index [3]]]
[member:5, state:*entry.signatureCompleteState] Transitioned to new state
[member:5, state:*entry.entrySubmissionState] Transitioning to a new state at block [47566]...
error creating threshold signature for request [2]: [failed to initiate new state [blocking member index [1]]]
[member:4, state:*entry.signatureCompleteState] Transitioned to new state
[member:4, state:*entry.entrySubmissionState] Transitioning to a new state at block [47566]...
error creating threshold signature for request [2]: [failed to initiate new state [blocking member index [4]]]
[member:5] Waiting for block [47578] to submit...
[member:5] Submitting relay entry..
Group selection started [&{NewEntry:+59349521601226944235574872895907257508492248931772837984180811443058308273889 RequestID:+2 Seed:+53067088278316309045121968048462724729152109215234493179134844471987707841858 BlockNumber:47579}]
New relay entry generated [&{RequestID:+2 Value:+59349521601226944235574872895907257508492248931772837984180811443058308273889 GroupPubKey:[148 201 102 80 168 175 134 22 57 88 174 102 140 6 86 157 161 253 198 211 221 66 2 185 54 173 121 213 147 68 47 34 3 106 162 84 138 240 215 67 22 146 199 110 198 201 30 30 165 163 237 77 177 130 240 136 9 94 34 95 134 202 253 107] PreviousEntry:+10920102476789591414949377782104707130412218726336356788412941355500907533021 Timestamp:2019-07-02 12:55:25.804585 +0000 UTC Seed:+53067088278316309045121968048462724729152109215234493179134844471987707841858 BlockNumber:47579}]
New relay entry generated at block number [47579]
[member:5] Relay entry for request [2] successfully submitted at block [47579]
[...]

We have decided to query operator contracts instead to avoid duplicated storage.

Setting new group size should only be possible in the event of contract upgrade.

…plete

Using <noun><action> naming for consistency.

…ents Upgradeable contract components implementation Implements RFC5 upgradeable contract components scheme. Adds minor refactoring to reduce the amount of repeated code. Further additions required to fully match RFC5, saving these for a separate PR: createGroup() method on Operator contract Service contract to select operator on requestRelayEntry()

- Set relayRequestTimeout to 17 - Modified sign(..) function by adding require(..) to handle timeout - Added tests

…core into relay-request-timeout

Shadowfiend · 2019-07-09T20:02:05Z

👋 would be useful to capture why we closed this PR :)

dimpar · 2019-07-10T07:55:29Z

The relay request timeout is a relatively small change. Because of Nik's changes, my code was sort of dependent on his work and I created this branch out of his. However, looking now at the history and trying to navigate to my actual changes is a bit confusing. I created a new branch from master (when Nik's changes were merged) for the timeout relay request, it's here. Way easier to look at and review.

pdyraga · 2019-07-10T07:57:47Z

Couldn't we rebase to master after merging Nik's PR? 🤔

dimpar · 2019-07-10T08:00:26Z

I tried.. but along the way had also some conflicts and just more headache. It was easier to create a new branch.

ngrinkevich added 30 commits April 27, 2019 10:55

Remove proxy and eternal storage setup from Keep Group contract

942c440

First step as part of the refactoring this contract as immutable back-end for the random beacon. Removing getters for the constants since these are now auto-generated from public variables.

Move withdrawal functionality into a mixin contract

6379be6

Minor folder restructure

46b0618

Rename KeepGroup to KeepRandomBeaconBackend

f331f0c

Rename KeepRandomBeacon to KeepRandomBeaconFrontend

1cc8238

Rename GroupContract to BackendContract

57b3cb2

Use better names for backend/frontend beacon layout in js tests

00e1fec

Split request and relay entry functionality between frontend and back…

f91d7ac

…end contract

Minor cleanup in tests

58d12fa

More renaming + cleanup

a36fef3

Update go code to perform relay entry on the backend contract

f6f0df0

Update go code to watch relay request on the backend contract

5355ffe

Rename previousEntry to groupSelectionSeed

57ec6a6

Backend contract should not track beacon entries and only needs to hold the last entry used as a selection seed for the next group selection run.

Save selection seed on group selection start

4ea4cf3

Make sure frontend sends signing group selection seed to the backend

47e962a

Refactor contract initialization with a helper

0880a99

Merge branch 'master' into upgradeable-contract-components

78e71a5

Refactor init script to accept a list of contracts

ed97496

This is useful in case of using specific stub contracts in tests.

Fix group selection tests

cd1c77f

Refactor group expiration tests with contracts init helper

b7b4af3

Remove accidentally added files during merge conflict

53b072a

Cleanup and fix solidity tests

1345752

Speed up solidity tests

0b1d09b

Use 'before' instead of 'beforeEach' where possible.

Fix small balance check in withdraw ether test

fe162ad

Update go code to new backend/frontend naming

cb440a1

Use simpler name for KeepRandomBeaconFrontend proxy contract

d9aa152

Include backend contracts during contract generation

619f25b

Make sure relay entry and its events set to backend contract

8ac0311

Merge branch 'master' into upgradeable-contract-components

c4636f6

Rename Backend contract to Operator contract

8627b9d

ngrinkevich and others added 4 commits June 29, 2019 12:25

Minor cleanup

8e953d0

Remove KeepRandomBeaconService from Go side

159faa1

This contract is not used by the Keep client, CLI for relay requests has been implemented with truffle scripts and located in `contract/scripts`.

Compile contracts before truffle test

f63207d

Adding a relay request timeout to block processing upcoming requests

31666b2

- Set relayRequestTimeout to 17 - Modified sign(..) function by adding require(..) to handle timeout - Added tests

Removing accidental change to package.json

7c96a73

dimpar mentioned this pull request Jul 2, 2019

Adding a relay request timeout to block processing upcoming requests #895

Closed

ngrinkevich and others added 16 commits July 3, 2019 08:13

Minor comments improvements

b4df69b

Rename requestID to signingId

3c84d71

Rename Request to SigningRequest

9dc8c83

Rename entryId to requestId

44127d2

Move initialize() to the top of the file

a4b3354

Remove number of groups storage from service contracts

42a64ac

We have decided to query operator contracts instead to avoid duplicated storage.

Remove setGroupSize

4533cb0

Setting new group size should only be possible in the event of contract upgrade.

Rename operator relay entry events to SigningRequested and SigningCom…

0517d8a

…plete

Use better names for signing request events

2b87246

Using <noun><action> naming for consistency.

Adding a relay request timeout to block processing upcoming requests

76be2dc

- Set relayRequestTimeout to 17 - Modified sign(..) function by adding require(..) to handle timeout - Added tests

Removing accidental change to package.json

ea0bb8f

Merge branch 'relay-request-timeout' of github.com:keep-network/keep-…

afd7dc9

…core into relay-request-timeout

Adding relay request timeout

d0e26c3

Removing accidental change to package.json

86e2f5e

Merge branch 'relay-request-timeout' of github.com:keep-network/keep-…

9e07ab3

…core into relay-request-timeout

dimpar closed this Jul 4, 2019

dimpar deleted the relay-request-timeout branch July 4, 2019 15:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Relay request timeout #897

Relay request timeout #897

dimpar commented Jul 2, 2019

dimpar commented Jul 2, 2019 •

edited

Loading

dimpar commented Jul 2, 2019 •

edited

Loading

Shadowfiend commented Jul 9, 2019

dimpar commented Jul 10, 2019

pdyraga commented Jul 10, 2019

dimpar commented Jul 10, 2019

Relay request timeout #897

Relay request timeout #897

Conversation

dimpar commented Jul 2, 2019

dimpar commented Jul 2, 2019 • edited Loading

dimpar commented Jul 2, 2019 • edited Loading

Shadowfiend commented Jul 9, 2019

dimpar commented Jul 10, 2019

pdyraga commented Jul 10, 2019

dimpar commented Jul 10, 2019

dimpar commented Jul 2, 2019 •

edited

Loading

dimpar commented Jul 2, 2019 •

edited

Loading