Return an error if estimated deposit sweep fee is too high #3666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #3614
Here we change the default behavior of the wallet maintainer (and
maintainer-clitool) when the estimated deposit sweep fee exceeds the maximum value allowed by theBridge. So far, the estimated fee was adjusted to the maximum allowed value. Now, an error is returned. That's because this is an abnormal situation and the maintainer should rather wait until the fee goes back to normal value than block the wallet in theWalletCoordinatorwith something that has no chance of being included in a block.