Estimate redemption transaction fee during proposal #3651
Conversation
pkg/coordinator/redemptions.go
Outdated
| case bitcoin.P2WSHScript: | ||
| sizeEstimator.AddScriptHashOutputs(1, true) | ||
| default: | ||
| panic("non-standard redeemer output script type") |
There was a problem hiding this comment.
I am not sure if we should trust the contract validation that much. We can have an upgrade and change the on-chain logic. I think it is OK to assume the script has to be one of the four types listed before but if it is not I would rather return an error, log it, and decide not to propose a redemption instead of killing the process.
At some point in the future
There was a problem hiding this comment.
The main purpose of this panic is to signal that something changed on the contract side and requires our attention. I'm afraid that returning an error and just logging it may not be visible enough. WDYT?
There was a problem hiding this comment.
I think the client should panic only if there is no way out. Here there is a way out - we can decide not to propose a redemption and eventually, we can even skip the given script when proposing the redemption. Agreed about calling the attention but I would address it somewhere else, e.g. have a script type for every redemption request at tbtcscan.com
Refs #3614
Here we add a function allowing us to estimate the redemption transaction total fee (
coordinator.EstimateRedemptionFee) and we integrate it with the existingcoordinator.ProposeRedemptionfunction.