Redemptions prototype: Assemble BTC redemption transaction #3607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here we add the `assembleRedemptionTransaction` function that allows to assemble an unsigned BTC redemption transaction.
Production code requires that the change output is always placed as the first one in the output vector to leverage the gas optimizations made in the Bridge implementation. However, the existing testnet transactions we are planning to use for unit tests have the change output as the last one. In order to mitigate that difference, we add support for both transaction shapes.
3 tasks
pdyraga
reviewed
Jun 9, 2023
pdyraga
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #3609
Here we introduce the
assembleRedemptionTransactionfunction that allows constructing an unsigned Bitcoin redemption transaction based on provided input arguments.