Only netstandard projects #135
Conversation
…build/solution configs that were for netfx/netstandard subsets of those projects.
…f it seems useful for CI builds later.
…d projects and build the new .nupkg.
… report 0%, so try filtering those namespaces.
| "the SharedVersionInfo.cs file. Then, tries to create a new NuGet package, which will fail if " | ||
| "nuget.exe isn't in the PATH or the script's directory.`n" | ||
| "Updates the Version in the .csproj file. Then, tries to create a new NuGet package, which will" | ||
| "fail if nuget.exe isn't in the PATH or the script's directory.`n" |
There was a problem hiding this comment.
This comment is wrong, since we aren't directly using nuget.exe but rather rely on the dotnet core tools being installed, so I'll need to fix that.
There was a problem hiding this comment.
Fixed in another commit.
.appveyor.yml
Outdated
| @@ -102,7 +96,7 @@ test_script: | |||
| # | |||
| # Also use -oldStyle flag which uses an alternate instrumentation hook that is available for .NET Core | |||
| # Some comments on this can be found here: https://github.com/OpenCover/opencover/issues/601 | |||
| - .\tools\OpenCover.4.6.519\tools\OpenCover.Console.exe -target:dotnet.exe -targetargs:"test --logger \"trx;LogFileName=netstandard_test_results.xml\" .\Keen.NetStandard.Test\Keen.NetStandard.Test.csproj /property:DebugType=Full" -mergeoutput -output:coverage.xml -filter:"+[*]* -[*.Test]*" -oldStyle -returntargetcode -register:user | |||
| - .\tools\OpenCover.4.6.519\tools\OpenCover.Console.exe -target:dotnet.exe -targetargs:"test --logger \"trx;LogFileName=netstandard_test_results.xml\" .\Keen.NetStandard.Test\Keen.NetStandard.Test.csproj /property:DebugType=Full" -mergeoutput -output:coverage.xml -filter:"+[*]* -[*.Test]* -[Moq*]*" -oldStyle -returntargetcode -register:user | |||
|
|
|||
| # Upload merged coverage results from both test runs | |||
There was a problem hiding this comment.
This comment is outdated.
There was a problem hiding this comment.
Ha, I was looking at OpenCover Issue 601 thinking you meant the -oldStyle flag wasn't needed anymore, but then I realized you were referring to the "from both test runs" part 😆, will fix.
… to old solution structure.
|
Merging even though the MacOS CI job hasn't finished...changes since last successful MacOS build are comment-only. If there's an issue, I'll deal with the merge of this and PR #136 directly in |
Remove the 3.5/4.5/PCL projects, so now there's only the netstandard2.0/netfx4.5 multi-targeted project and the netcore2.0 test project.
Lots of moved files, so the interesting parts are the .sln/.csproj and config/script/props files related to building/packing/CI/testing/etc.