Make the configuration of the version more user-friendly #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The client expects the version to be a string '3.0'. This change allows to configure the version as a float by formatting it properly, to make it possible to use the unquoted syntax in Yaml, which will produce a float. Note that the config file in the test fixtures was already using a float, but the tests were not failing because the service was not instantiated.
k-k
approved these changes
Apr 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client expects the version to be a string '3.0'. This change allows to configure the version as a float by formatting it properly, to make it possible to use the unquoted syntax in Yaml, which will produce a float.
Note that the config file in the test fixtures was already using a float, but the tests were not failing because the service was not instantiated.