Properly handle negative value assigned to Meta.historyMaxItems
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Make `Meta.maintenanceHistoryDays` unsigned
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## develop #30 +/- ##
===========================================
+ Coverage 74.01% 74.21% +0.19%
===========================================
Files 98 98
Lines 3948 3959 +11
Branches 624 626 +2
===========================================
+ Hits 2922 2938 +16
+ Misses 700 699 -1
+ Partials 326 322 -4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Library incorrectly relied on
historyMaxItemsbeing non-negative. This change properly treats negative value as a marker for „unlimited” history entries.maintenanceHistoryDayswas also changed to unsigned in order to reflect expected values.