Add an option for kedro new to skip telemetry #3701

lrcouto · 2024-03-12T16:59:04Z

Description

Adds a new --telemetry or -tc flag for kedro new which allows the user to sign their consent for usage analytics collection on the moment of the creation of the project, and skipping the prompt for analytics collection on the moment where the kedro command is first invoked inside the project directory.

Development notes

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

Read the contributing guidelines
Signed off each commit with a Developer Certificate of Origin (DCO)
Opened this PR as a 'Draft Pull Request' if it is work-in-progress
Updated the documentation to reflect the code changes
Added a description of this change in the RELEASE.md file
Added tests to cover my changes
Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: lrcouto <laurarccouto@gmail.com>

DimedS

Thank you for the PR, @lrcouto! Looks good to me, I've left some minor comments.

DimedS · 2024-03-13T10:23:33Z

kedro/framework/cli/starters.py

@@ -269,6 +275,7 @@ def new(  # noqa: PLR0913
    checkout: str,
    directory: str,
    example_pipeline: str,  # This will be True or False


Suggested change

example_pipeline: str, # This will be True or False

example_pipeline: str,

telemetry_consent: str,

It seems the comment is outdated. Previously, the example_pipeline was returned with Click preprocessed to contain True/False values. However, it now retains its original 'y'/'no' values. It would be best to remove this comment.

DimedS · 2024-03-13T10:25:43Z

kedro/framework/cli/starters.py

@@ -876,7 +890,9 @@ def _validate_range(start: Any, end: Any) -> None:
    return selected


-def _create_project(template_path: str, cookiecutter_args: dict[str, Any]) -> None:
+def _create_project(
+    template_path: str, cookiecutter_args: dict[str, Any], telemetry_consent: str


Is it telemetry_consent: str|None?

Signed-off-by: lrcouto <laurarccouto@gmail.com>

noklam

Not much comments about the implementation since it's quite similar to example pipelines, but more on why we want to keep yes no instead of just a default boolean, similar to kedro run --async

noklam · 2024-03-13T13:41:26Z

docs/source/get_started/new_project.md

+### Telemetry consent
+
+The `--telemetry` flag offers the option to register consent to have user analytics collected in the moment of the creation of the project. This option bypasses the prompt to collect analytics that would otherwise appear on the moment the `kedro` command is invoked for the first time inside the project. In case the `--telemetry` flag is not used, the user will be prompted to accept or reject analytics collection as usual.
+
+When creating your new Kedro project, use the values `yes` or `no` to register consent to have user analytics collected for this specific project.


I guess this is same question for example_pipeline, is there a reason why we cannot simplify this to --skip-telemetry, when not used it just prompt as usual, otherwise just default to No? I am sure no one want to type out --telemetry no since it's redundant.

It's also a bit surprising that --telemetry yes doesn't mean accept telemetry, but rather yes to be prompted.

--telemetry yes would mean consenting to telemetry, while no would mean not consenting. Both of those skip the prompt. I think my wording there might've been unclear.

I've used the yes/no options because they mirror what's given to the user by the prompt when they run the kedro command for the first time.

I believe here and for example_pipeline, we should leave it as it is: with yes/no option. Because if you want to choose --telemetry=yes, --skip-telemetry will not provide you that option.

@lrcouto @DimedS Thanks for clarifying!

I'm happy with --telemetry yes/no 👍🏽

noklam · 2024-03-13T13:43:48Z

kedro/framework/cli/starters.py

+TELEMETRY_ARG_HELP = """Allow or not allow Kedro to collect usage analytics.
+We cannot see nor store information contained into a Kedro project. Opt in with "yes"
+and out with "no".
+"""


I will take some reference from https://github.com/kedro-org/kedro-plugins/tree/main/kedro-telemetry, but probably get advice from @astrojuanlu since we need to be careful about the wordings. We did collect some Project information, such as number of pipelines, datasets, but they are anonymous.

That's a good point, I will let him know.

I would copy the definition from the regex function as it's more descriptive:

It must contain only y, n, YES, or NO (case insensitive).

DimedS

Thank you, @lrcouto , LGTM!

docs/source/get_started/new_project.md

merelcht · 2024-03-14T12:26:10Z

tests/framework/cli/test_starters.py

@@ -1562,3 +1562,119 @@ def test_convert_tool_short_names_to_numbers_with_duplicates(self):
        selected_tools = "lint,test,tests"
        result = _convert_tool_short_names_to_numbers(selected_tools)
        assert result == ["1", "2"]
+
+
+@pytest.mark.usefixtures("chdir_to_tmp")


test_starters is becoming so long 🥲 Might be time to prioritise: #3594

Moving the tests related to tools to their own file and maybe moving auxiliary functions to their own file as well would probably solve half ot it.

Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com>

Signed-off-by: lrcouto <laurarccouto@gmail.com>

…o into add-option-skip-telemetry

Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com>

astrojuanlu

I was discussing this with @iamelijahko and I am not 100 % sure we are solving the root cause here. Sorry for being so late to the party, should have anticipated this earlier.

The original problem is that Kedro gets stuck in certain non-interactive environments #1640. The current workarounds are

echo "consent: false" > .telemetry and then continue. Unintuitive.
Uninstall kedro-telemetry altogether. We've been counseling this to Databricks users.

Discussion about this issue is a bit scattered, there's a bit more context in #2867 of course.

Adding this flag to kedro new (whatever name it takes, we can discuss about that later) would help users that run kedro new on these unattended environments, but my understanding is that the large majority actually run kedro run and the like. So this would not help them.

In other words: I don't recall seeing evidence that users create new projects on CI environments.

Can we discuss this a bit further before proceeding?

datajoely · 2024-03-19T11:25:55Z

@astrojuanlu I take your point - but I think we need this at creation time AND at kedro <within project commands> time

I wonder if we can have a catch all workflow for any command that triggers the telemetry consent prompt to accept this flag 🤔

astrojuanlu · 2024-03-19T11:34:02Z

That's fair enough - if so, I contend that whatever we do

We better do it with the whole CLI in mind,
Probably as a PR to kedro-telemetry if at all possible?? Given that it's the one prompting for consent (otherwise this creates some weird separation of concerns issues), and
Bearing in mind that at some point these flags might not make sense if we move towards non-interactive consent by default

noklam · 2024-03-19T12:16:19Z

#1640 was the original issue, I did recall the workaround of yes | kedro new. I agree this doesn't solve the whole problem particular for kedro run.

merelcht · 2024-03-22T15:25:44Z

I see the point of covering the full CLI commands, but my guess is that if we add a flag to kedro new and kedro run we solve about 90% of the cases where a kedro command is run in a CI type of environment.

Probably as a PR to kedro-telemetry if at all possible?? Given that it's the one prompting for consent (otherwise this creates some weird separation of concerns issues)

I like the sound of this, but have no idea if that's possible.

My suggestion would be to merge this PR and add a similar flag to kedro run. We can do a spike to figure out if we could do it for the whole CLI from kedro-telemetry, but IMO that's lower priority.

datajoely · 2024-03-22T15:33:32Z

@merelcht I agree! 80/20 approach is fine.

Unblocking this PR in light of current consensus

astrojuanlu · 2024-03-25T15:52:20Z

Any other design aspect of this that requires @iamelijahko input?

Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com>

astrojuanlu

Let's get this merged!

* First draft for telemetry consent flag on kedro new Signed-off-by: lrcouto <laurarccouto@gmail.com> * Add functioning --telemetry option to kedro new Signed-off-by: lrcouto <laurarccouto@gmail.com> * Update tests to acknowledge new flag Signed-off-by: lrcouto <laurarccouto@gmail.com> * Add tests for kedro new --telemetry flag Signed-off-by: lrcouto <laurarccouto@gmail.com> * Add changes to documentation and release notes Signed-off-by: lrcouto <laurarccouto@gmail.com> * Minor change to docs Signed-off-by: lrcouto <laurarccouto@gmail.com> * Lint Signed-off-by: lrcouto <laurarccouto@gmail.com> * Remove outdated comment and correct type hint Signed-off-by: lrcouto <laurarccouto@gmail.com> * Update docs/source/get_started/new_project.md Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> * Lint Signed-off-by: lrcouto <laurarccouto@gmail.com> * Minor change on release note Signed-off-by: lrcouto <laurarccouto@gmail.com> --------- Signed-off-by: lrcouto <laurarccouto@gmail.com> Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

) * Update kedro-catalog-0.19.json (#3724) * Update kedro-catalog-0.19.json Signed-off-by: Anthony De Bortoli <anthony.debortoli@protonmail.com> * Update set_up_vscode.md Signed-off-by: Anthony De Bortoli <anthony.debortoli@protonmail.com> --------- Signed-off-by: Anthony De Bortoli <anthony.debortoli@protonmail.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Update project tests directory structure in docs Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add docs on writing tests Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Drop dependency on toposort in favour of built-in graphlib (#3728) * Replace toposort with graphlib (built-in from Python 3.9) Signed-off-by: Ivan Danov <idanov@users.noreply.github.com> * Create toposort groups only when needed Signed-off-by: Ivan Danov <idanov@users.noreply.github.com> * Update RELEASE.md and graphlib version constraints Signed-off-by: Ivan Danov <idanov@users.noreply.github.com> * Remove mypy-toposort Signed-off-by: Ivan Danov <idanov@users.noreply.github.com> * Ensure that the suggest resume test has no node ordering requirement Signed-off-by: Ivan Danov <idanov@users.noreply.github.com> * Ensure stable toposorting by grouping and ungrouping the result Signed-off-by: Ivan Danov <idanov@users.noreply.github.com> --------- Signed-off-by: Ivan Danov <idanov@users.noreply.github.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Optimise pipeline addition and creation (#3730) * Create toposort groups only when needed * Ensure that the suggest resume test has no node ordering requirement * Ensure stable toposorting by grouping and ungrouping the result * Delay toposorting until pipeline.nodes is used * Avoid using .nodes when topological order or new copy is unneeded * Copy the nodes only if tags are provided * Remove unnecessary condition in self.nodes Signed-off-by: Ivan Danov <idanov@users.noreply.github.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Expand robots.txt for Kedro-Viz and Kedro-Datasets docs (#3729) * Add project to robots.txt Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com> * Add EOF Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com> --------- Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com> Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Kedro need more uv (#3740) * Kedro need more uv Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * remove docker Signed-off-by: Nok <nok.lam.chan@quantumblack.com> --------- Signed-off-by: Nok <nok.lam.chan@quantumblack.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Resolve all path in Kedro (#3742) * Kedro need more uv Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * remove docker Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * fix broken type hint and resolve project path Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * fix type hint Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * remove duplicate logic Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * adding nok.py is definitely an accident Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * fix test Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * remove print Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * add test Signed-off-by: Nok <nok.lam.chan@quantumblack.com> --------- Signed-off-by: Nok <nok.lam.chan@quantumblack.com> Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Remove settings of rate limits and retries (#3769) * double linkcheck limits Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * fix ratelimit Signed-off-by: Nok <nok.lam.chan@quantumblack.com> --------- Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> Signed-off-by: Nok <nok.lam.chan@quantumblack.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Improve resume suggestions (#3719) * Improve suggestions to resume a failed pipeline - if dataset (or param) is persistent & shared, don't keep looking for ancestors - only look for ancestors producing impersistent inputs - minimize number of suggested nodes (= shorter message for the same pipeline) - testable logic, tests cases outside of scenarios for sequential runner - Use _EPHEMERAL attribute - Move tests to separate file - Docstring updates --------- Signed-off-by: Ondrej Zacha <ondrej.zacha@okra.ai> Co-authored-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Build docs fix (#3773) * Ignored forbidden url Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Returned linkscheck retries Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed odd comment Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> --------- Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Clarify docs around custom resolvers (#3759) * Updated custom resolver docs section Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated advanced configuration section for consistency Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated RELEASE.md Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated RELEASE.md Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Test linkcheck_workers decrease Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Increased the By default, the linkcheck_rate_limit_timeout to default Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Returned old docs build settings Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed typo Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Ignore forbidden url Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Returned linkcheck retries Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> --------- Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add mlruns to gitignore to avoid pushing mlflow local runs to github (#3765) * Add mlruns to gitignore to avoid pushing mlflow local runs to github Signed-off-by: Yolan Honoré-Rougé <yolan.honore.rouge@gmail.com> * update release.md Signed-off-by: Yolan Honoré-Rougé <yolan.honore.rouge@gmail.com> --------- Signed-off-by: Yolan Honoré-Rougé <yolan.honore.rouge@gmail.com> Signed-off-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Co-authored-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Update the dependencies page in the docs (#3772) * Update the dependencies page Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update docs/source/kedro_project_setup/dependencies.md Signed-off-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com> Signed-off-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com> * Fix lint Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Move the last line to notes Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> --------- Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> Signed-off-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com> Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Change pipeline test location to project root/tests (#3731) * Change pipeline test location to project root/tests Signed-off-by: lrcouto <laurarccouto@gmail.com> * Fix some test_pipeline tests Signed-off-by: lrcouto <laurarccouto@gmail.com> * Change delete pipeline to account for new structure Signed-off-by: lrcouto <laurarccouto@gmail.com> * Fix some tests Signed-off-by: lrcouto <laurarccouto@gmail.com> * Change tests path on micropkg Signed-off-by: lrcouto <laurarccouto@gmail.com> * Fix remaining tests Signed-off-by: lrcouto <laurarccouto@gmail.com> * Add changes to release notes Signed-off-by: lrcouto <laurarccouto@gmail.com> * Update file structure on micropackaging doc page Signed-off-by: lrcouto <laurarccouto@gmail.com> --------- Signed-off-by: lrcouto <laurarccouto@gmail.com> Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add an option for kedro new to skip telemetry (#3701) * First draft for telemetry consent flag on kedro new Signed-off-by: lrcouto <laurarccouto@gmail.com> * Add functioning --telemetry option to kedro new Signed-off-by: lrcouto <laurarccouto@gmail.com> * Update tests to acknowledge new flag Signed-off-by: lrcouto <laurarccouto@gmail.com> * Add tests for kedro new --telemetry flag Signed-off-by: lrcouto <laurarccouto@gmail.com> * Add changes to documentation and release notes Signed-off-by: lrcouto <laurarccouto@gmail.com> * Minor change to docs Signed-off-by: lrcouto <laurarccouto@gmail.com> * Lint Signed-off-by: lrcouto <laurarccouto@gmail.com> * Remove outdated comment and correct type hint Signed-off-by: lrcouto <laurarccouto@gmail.com> * Update docs/source/get_started/new_project.md Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> * Lint Signed-off-by: lrcouto <laurarccouto@gmail.com> * Minor change on release note Signed-off-by: lrcouto <laurarccouto@gmail.com> --------- Signed-off-by: lrcouto <laurarccouto@gmail.com> Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Update documentation for OmegaConfigLoader (#3778) * Update documentation for OmegaConfigLoader Signed-off-by: Puneet Saini <99470400+puneeter@users.noreply.github.com> * Update RELEASE.md Signed-off-by: Puneet Saini <99470400+puneeter@users.noreply.github.com> * Update RELEASE.md Signed-off-by: Puneet Saini <99470400+puneeter@users.noreply.github.com> * Update ignore-names.txt Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> --------- Signed-off-by: Puneet Saini <99470400+puneeter@users.noreply.github.com> Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Fix path Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Lint Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add changes to RELEASE.md Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Address comments from code review Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Empty Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Remove unneeded imports Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Change recommendation from pytest config to editable install Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add negative testing example Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Replace Dict with dict Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Remove test classes Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Change the assert step for the integration test Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Fix error handling for OmegaConfigLoader (#3784) * Update omegaconf_config.py Signed-off-by: Puneet Saini <99470400+puneeter@users.noreply.github.com> * Update RELEASE.md Signed-off-by: Puneet Saini <99470400+puneeter@users.noreply.github.com> * add a more complicated test case Signed-off-by: Nok <nok.lam.chan@quantumblack.com> --------- Signed-off-by: Puneet Saini <99470400+puneeter@users.noreply.github.com> Signed-off-by: Nok <nok.lam.chan@quantumblack.com> Co-authored-by: Nok <nok.lam.chan@quantumblack.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add Simon Brugman to TSC (#3780) Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Update technical_steering_committee.md (#3796) Signed-off-by: Marcin Zabłocki <m.zablo@gmail.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Remove jmespath dependency (#3797) Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Update spaceflights tutorial and starter requirements for kedro-datasets optional dependencies (#3664) * Update spaceflights tutorial and starter requirements Signed-off-by: lrcouto <laurarccouto@gmail.com> * fix e2e tests Signed-off-by: lrcouto <laurarccouto@gmail.com> * Fix e2e tests by distinguishing `kedro-datasets` dependency for different python versions (#3802) Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com> * Update docs/source/tutorial/tutorial_template.md Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> --------- Signed-off-by: lrcouto <laurarccouto@gmail.com> Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com> Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Consider Vale's suggestions Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Hide test in details Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Quick fix Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Typo (and wording changes) Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Update robots.txt (#3803) Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add a test for transcoding loops of 1 or more nodes (#3810) Signed-off-by: Ivan Danov <idanov@users.noreply.github.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Ensure no nodes can depend on themselves even when transcoding is used (#3812) * Factor out transcoding helpers into a private module Signed-off-by: Ivan Danov <idanov@users.noreply.github.com> * Ensure node input/output validation doesn't allow transcoded self-loops Signed-off-by: Ivan Danov <idanov@users.noreply.github.com> * Updated release note to avoid github warning Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> --------- Signed-off-by: Ivan Danov <idanov@users.noreply.github.com> Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> Co-authored-by: Elena Khaustova <ymax70rus@gmail.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Update UUID telemetry docs (#3805) Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Change path to starters test (#3816) Signed-off-by: lrcouto <laurarccouto@gmail.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Move changes in RELEASE.md to docs section Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Change formatting Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Revert "Change formatting" This reverts commit 9582a22. Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Apply changes from code review Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add explanation on why cleanup isn't needed Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Change assert on successful pipeline to check logs Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Update description of integration test under pipeline slicing Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Missing formatting Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Update tests directory structure Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> --------- Signed-off-by: Anthony De Bortoli <anthony.debortoli@protonmail.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> Signed-off-by: Ivan Danov <idanov@users.noreply.github.com> Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com> Signed-off-by: Nok <nok.lam.chan@quantumblack.com> Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> Signed-off-by: Ondrej Zacha <ondrej.zacha@okra.ai> Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> Signed-off-by: Yolan Honoré-Rougé <yolan.honore.rouge@gmail.com> Signed-off-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> Signed-off-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com> Signed-off-by: lrcouto <laurarccouto@gmail.com> Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> Signed-off-by: Puneet Saini <99470400+puneeter@users.noreply.github.com> Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> Signed-off-by: Marcin Zabłocki <m.zablo@gmail.com> Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com> Signed-off-by: Ahdra Merali <90615669+AhdraMeraliQB@users.noreply.github.com> Co-authored-by: Anthony De Bortoli <anthony.debortoli@protonmail.com> Co-authored-by: Ivan Danov <idanov@users.noreply.github.com> Co-authored-by: Dmitry Sorokin <40151847+DimedS@users.noreply.github.com> Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> Co-authored-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> Co-authored-by: Ondrej Zacha <ondrej.zacha@okra.ai> Co-authored-by: ElenaKhaustova <157851531+ElenaKhaustova@users.noreply.github.com> Co-authored-by: Yolan Honoré-Rougé <29451317+Galileo-Galilei@users.noreply.github.com> Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Co-authored-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com> Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com> Co-authored-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> Co-authored-by: Puneet Saini <99470400+puneeter@users.noreply.github.com> Co-authored-by: Marcin Zabłocki <m.zablo@gmail.com> Co-authored-by: Elena Khaustova <ymax70rus@gmail.com>

lrcouto and others added 6 commits March 11, 2024 19:25

First draft for telemetry consent flag on kedro new

90fcd26

Signed-off-by: lrcouto <laurarccouto@gmail.com>

Add functioning --telemetry option to kedro new

8d0d13b

Signed-off-by: lrcouto <laurarccouto@gmail.com>

Merge branch 'main' into add-option-skip-telemetry

a8b0036

Update tests to acknowledge new flag

482d093

Signed-off-by: lrcouto <laurarccouto@gmail.com>

Add tests for kedro new --telemetry flag

6504100

Signed-off-by: lrcouto <laurarccouto@gmail.com>

Add changes to documentation and release notes

09f174b

Signed-off-by: lrcouto <laurarccouto@gmail.com>

lrcouto marked this pull request as ready for review March 13, 2024 05:06

lrcouto requested review from yetudada, astrojuanlu and merelcht as code owners March 13, 2024 05:06

lrcouto linked an issue Mar 13, 2024 that may be closed by this pull request

Add an option for kedro new and kedro run to skip telemetry (e.g. for CI/CD environment) #2867

Closed

lrcouto requested review from DimedS, ankatiyar and AhdraMeraliQB March 13, 2024 05:07

lrcouto added 2 commits March 13, 2024 02:14

Minor change to docs

8917e85

Signed-off-by: lrcouto <laurarccouto@gmail.com>

Lint

2b3b046

Signed-off-by: lrcouto <laurarccouto@gmail.com>

DimedS requested changes Mar 13, 2024

View reviewed changes

lrcouto and others added 2 commits March 13, 2024 10:19

Merge branch 'main' into add-option-skip-telemetry

583e5e7

Remove outdated comment and correct type hint

f8254d0

Signed-off-by: lrcouto <laurarccouto@gmail.com>

lrcouto requested a review from noklam March 13, 2024 13:35

noklam reviewed Mar 13, 2024

View reviewed changes

Merge branch 'main' into add-option-skip-telemetry

fb5a876

DimedS approved these changes Mar 14, 2024

View reviewed changes

merelcht reviewed Mar 14, 2024

View reviewed changes

docs/source/get_started/new_project.md Outdated Show resolved Hide resolved

merelcht reviewed Mar 14, 2024

View reviewed changes

lrcouto and others added 3 commits March 14, 2024 10:27

Merge branch 'main' into add-option-skip-telemetry

c2c3906

Update docs/source/get_started/new_project.md

650f37c

Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com>

Lint

19ac1e7

Signed-off-by: lrcouto <laurarccouto@gmail.com>

lrcouto self-assigned this Mar 15, 2024

Merge branch 'main' into add-option-skip-telemetry

ecc3780

lrcouto and others added 5 commits March 16, 2024 18:18

Minor change on release note

329b05f

Signed-off-by: lrcouto <laurarccouto@gmail.com>

Merge branch 'add-option-skip-telemetry' of github.com:kedro-org/kedr…

31089ee

…o into add-option-skip-telemetry

Merge branch 'main' into add-option-skip-telemetry

39b9474

Merge branch 'main' into add-option-skip-telemetry

8733b2a

Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com>

Merge branch 'main' into add-option-skip-telemetry

6c4ce42

astrojuanlu previously requested changes Mar 19, 2024

View reviewed changes

astrojuanlu mentioned this pull request Mar 19, 2024

Add an option for kedro new and kedro run to skip telemetry (e.g. for CI/CD environment) #2867

Closed

Merge branch 'main' into add-option-skip-telemetry

c11f197

lrcouto added 8 commits March 26, 2024 11:51

Merge branch 'main' into add-option-skip-telemetry

b34539c

Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com>

Merge branch 'main' into add-option-skip-telemetry

3ee92fa

Merge branch 'main' into add-option-skip-telemetry

ef827ef

Merge branch 'main' into add-option-skip-telemetry

575929d

Merge branch 'main' into add-option-skip-telemetry

603c894

Merge branch 'main' into add-option-skip-telemetry

f9bcd70

Merge branch 'main' into add-option-skip-telemetry

29184db

Merge branch 'main' into add-option-skip-telemetry

51265e5

astrojuanlu approved these changes Apr 4, 2024

View reviewed changes

astrojuanlu merged commit 87773e8 into main Apr 4, 2024
41 checks passed

astrojuanlu deleted the add-option-skip-telemetry branch April 4, 2024 07:02

ankatiyar mentioned this pull request Apr 8, 2024

kedro-telemetry: Nightly build failure kedro-org/kedro-plugins#636

Closed

astrojuanlu mentioned this pull request May 23, 2024

feat: Exit before_command_run if telemetry consent is passed through kedro run kedro-org/kedro-plugins#681

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add an option for kedro new to skip telemetry #3701

Add an option for kedro new to skip telemetry #3701

lrcouto commented Mar 12, 2024 •

edited

Loading

DimedS left a comment

DimedS Mar 13, 2024

DimedS Mar 13, 2024

noklam left a comment •

edited

Loading

noklam Mar 13, 2024

lrcouto Mar 13, 2024 •

edited

Loading

DimedS Mar 14, 2024

noklam Mar 14, 2024

astrojuanlu Mar 25, 2024

noklam Mar 13, 2024

lrcouto Mar 13, 2024

datajoely Mar 19, 2024

DimedS left a comment

merelcht Mar 14, 2024

lrcouto Mar 14, 2024

astrojuanlu left a comment

datajoely commented Mar 19, 2024

astrojuanlu commented Mar 19, 2024

noklam commented Mar 19, 2024

merelcht commented Mar 22, 2024

datajoely commented Mar 22, 2024

astrojuanlu commented Mar 25, 2024

astrojuanlu left a comment

	example_pipeline: str, # This will be True or False
	example_pipeline: str,
	telemetry_consent: str,

Add an option for kedro new to skip telemetry #3701

Add an option for kedro new to skip telemetry #3701

Conversation

lrcouto commented Mar 12, 2024 • edited Loading

Description

Development notes

Developer Certificate of Origin

Checklist

DimedS left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

noklam left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lrcouto Mar 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DimedS left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

astrojuanlu left a comment

Choose a reason for hiding this comment

datajoely commented Mar 19, 2024

astrojuanlu commented Mar 19, 2024

noklam commented Mar 19, 2024

merelcht commented Mar 22, 2024

datajoely commented Mar 22, 2024

astrojuanlu commented Mar 25, 2024

astrojuanlu left a comment

Choose a reason for hiding this comment

lrcouto commented Mar 12, 2024 •

edited

Loading

noklam left a comment •

edited

Loading

lrcouto Mar 13, 2024 •

edited

Loading