Skip to content

Commit

Permalink
Adding a list of "path" keys to check dataset config against. (#3561)
Browse files Browse the repository at this point in the history
* Adding a list of "path" keys to check dataset config against.

Signed-off-by: MosaicMan <34198823+MosaicMan@users.noreply.github.com>

* Clean up `catalog resolve` CLI command to remove unnecessary checks.

- Remove filepath check from `resolve_patterns` method.
- Eliminate the associated `_trim_filepath` function.
- Update release notes.

These changes address redundant validations that were causing #3560.

Signed-off-by: MosaicMan <34198823+MosaicMan@users.noreply.github.com>

* Update release notes

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>

---------

Signed-off-by: MosaicMan <34198823+MosaicMan@users.noreply.github.com>
Signed-off-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com>
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Co-authored-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com>
Co-authored-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
  • Loading branch information
3 people authored Feb 2, 2024
1 parent a42a91e commit a0abbd1
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
4 changes: 4 additions & 0 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Major features and improvements

## Bug fixes and other changes
* Updated CLI Command `kedro catalog resolve` to work with dataset factories that use `PartitionedDataset`.
* Addressed arbitrary file write via archive extraction security vulnerability in micropackaging.
* Added the `_EPHEMERAL` attribute to `AbstractDataset` and other Dataset classes that inherit from it.

Expand All @@ -11,6 +12,9 @@
## Documentation changes

## Community contributions
Many thanks to the following Kedroids for contributing PRs to this release:
* [MosaicMan](https://github.com/MosaicMan)


# Release 0.19.2

Expand Down
7 changes: 0 additions & 7 deletions kedro/framework/cli/catalog.py
Original file line number Diff line number Diff line change
Expand Up @@ -265,13 +265,6 @@ def resolve_patterns(metadata: ProjectMetadata, env: str) -> None:
ds_name, matched_pattern, ds_config_copy
)

ds_config["filepath"] = _trim_filepath(
str(context.project_path) + "/", ds_config["filepath"]
)
explicit_datasets[ds_name] = ds_config

secho(yaml.dump(explicit_datasets))


def _trim_filepath(project_path: str, file_path: str) -> str:
return file_path.replace(project_path, "", 1)

0 comments on commit a0abbd1

Please sign in to comment.