refactor(airflow): Remove bootstrap_project
#599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
bootstrap_projectbootstrap_project
noklam
reviewed
Mar 12, 2024
Comment on lines
+98
to
+99
| type=click.Path(writable=True, resolve_path=False, file_okay=False), | ||
| default="airflow_dags/", |
There was a problem hiding this comment.
The target path shouldn't be resolved relative to the current directory at this point because it needs to be joined with the metadata.project_path later on.
Signed-off-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com>
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
merelcht
approved these changes
Mar 21, 2024
Comment on lines
+101
to
+103
| project_path = kedro_project.resolve() | ||
| metadata = bootstrap_project(project_path) | ||
| return metadata |
There was a problem hiding this comment.
Is this now necessary for the test setup because we don't call bootstrap_project in the actual flow anymore?
There was a problem hiding this comment.
Yeah, since we don't do it in the plugin code, it's necessary for the unit tests to run.
8 tasks
tgoelles
pushed a commit
to tgoelles/kedro-plugins
that referenced
this pull request
Jun 6, 2024
* Remove bootstrap_project Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Refactor Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Fix tests Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Print for debugging Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * add resolve Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update tests Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> --------- Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> Signed-off-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com> Signed-off-by: tgoelles <thomas.goelles@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following the discussion wrt kedro-org/kedro#3683
Development notes
bootstrap_projectand getproject_pathfrommetadataChecklist
RELEASE.mdfile