-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(datasets): pin PyArrow until 19.0.1
is out
#1006
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
6 tasks
deepyaman
commented
Feb 7, 2025
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
merelcht
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 👍
ankatiyar
approved these changes
Feb 10, 2025
CF-FHB-X
pushed a commit
to CF-FHB-X/kedro-plugins
that referenced
this pull request
Feb 18, 2025
* build(datasets): pin PyArrow until `19.0.1` is out Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * chore(datasets): exclude `19.0.0` instead of bound Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> --------- Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Signed-off-by: Richard <CF-FHB-X@users.noreply.github.com>
CF-FHB-X
pushed a commit
to CF-FHB-X/kedro-plugins
that referenced
this pull request
Feb 18, 2025
* build(datasets): pin PyArrow until `19.0.1` is out Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * chore(datasets): exclude `19.0.0` instead of bound Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> --------- Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Signed-off-by: Richard Asselin <richard.asselin@gmail.com>
ElenaKhaustova
added a commit
that referenced
this pull request
Feb 21, 2025
* build(datasets): Release 6.0.0 (#968) release draft Signed-off-by: Richard Asselin <richard.asselin@gmail.com> * chore(datasets): Remove tracking datasets which are used in Kedro Viz Experiment Tracking (#969) * remove et related kedro datasets * update release note and static json schema * temporary doc fix Signed-off-by: Richard Asselin <richard.asselin@gmail.com> * docs(datasets): Move to linkcode extension (#985) Move to linkcode extension Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> Signed-off-by: Richard Asselin <richard.asselin@gmail.com> * fix(datasets): Fix polars.CSVDataset `save` on Windows (#979) * test csv win Signed-off-by: ravi_kumar_pilla <ravi_kumar_pilla@mckinsey.com> * change ci yaml for testing Signed-off-by: ravi_kumar_pilla <ravi_kumar_pilla@mckinsey.com> * change ci yaml for testing Signed-off-by: ravi_kumar_pilla <ravi_kumar_pilla@mckinsey.com> * add default encoding when opening file * revert workflow tests Signed-off-by: ravi_kumar_pilla <ravi_kumar_pilla@mckinsey.com> * fix lint Signed-off-by: ravi_kumar_pilla <ravi_kumar_pilla@mckinsey.com> * update release note * update release note --------- Signed-off-by: ravi_kumar_pilla <ravi_kumar_pilla@mckinsey.com> Signed-off-by: Richard Asselin <richard.asselin@gmail.com> * feat(all): Replace trufflehog with detect-secrets (#983) * Removed trufflehog Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated github actions per plugin Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated release notes Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated validate-pr check scopes Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated lint command Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added key to trigger check Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated GH action to track per plugin Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed secret Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated GH for kedro-datasets Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated secrets baseline Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> --------- Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> Signed-off-by: Richard Asselin <richard.asselin@gmail.com> * build(datasets): use intersphinx over type_targets (#801) Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> Signed-off-by: Richard Asselin <richard.asselin@gmail.com> * fix(datasets): Add parameter to enable/disable lazy saving for `PartitionedDataset` (#978) * Replaced callable check Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updateds lazy_save test Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added test_callable_save Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed lint Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed docs links Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed all docs links Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated release notes Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed all docs links Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed typo Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added argument to disable lazy saving Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed save function argument Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated unit test Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed lint Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated related docs Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Revert test changes Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated baseline Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated release notes Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated release notes Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated docstrings Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> --------- Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> Signed-off-by: Richard Asselin <richard.asselin@gmail.com> * fix(datasets): use kwarg for Ibis `read_*` methods (#1005) * fix(datasets): use kwarg for Ibis `read_*` methods Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * Update RELEASE.md Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> --------- Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Signed-off-by: Richard Asselin <richard.asselin@gmail.com> * build(datasets): pin PyArrow until `19.0.1` is out (#1006) * build(datasets): pin PyArrow until `19.0.1` is out Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * chore(datasets): exclude `19.0.0` instead of bound Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> --------- Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Signed-off-by: Richard Asselin <richard.asselin@gmail.com> * build(datasets): update list of extras for Ibis 10 (#1003) * build(datasets): update list of extras for Ibis 10 Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * Update RELEASE.md Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> --------- Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Signed-off-by: Richard Asselin <richard.asselin@gmail.com> * chore: remove internal devtools from release notes (#1004) * chore: remove internal devtools from release notes Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * chore: remove internal devtools from release notes Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * chore: remove internal devtools from release notes Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * chore: remove internal devtools from release notes Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> --------- Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Signed-off-by: Richard Asselin <richard.asselin@gmail.com> * 998: Fixed case where MemoryDatasets in catalog wouldn't trigger `_is_memory_dataset` Signed-off-by: Richard Asselin <richard.asselin@gmail.com> * 998: Tests to ensure that MemoryDatasets are passed in mocked data catalog Signed-off-by: Richard Asselin <richard.asselin@gmail.com> * 998: Changelog Signed-off-by: Richard Asselin <richard.asselin@gmail.com> * 998: Linting fixes Signed-off-by: Richard Asselin <richard.asselin@gmail.com> * build(datasets): update list of extras for Ibis 10 (#1003) * build(datasets): update list of extras for Ibis 10 Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * Update RELEASE.md Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> --------- Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Signed-off-by: Richard <CF-FHB-X@users.noreply.github.com> Signed-off-by: Richard Asselin <richard.asselin@gmail.com> * chore: remove internal devtools from release notes (#1004) * chore: remove internal devtools from release notes Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * chore: remove internal devtools from release notes Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * chore: remove internal devtools from release notes Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * chore: remove internal devtools from release notes Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> --------- Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Signed-off-by: Richard <CF-FHB-X@users.noreply.github.com> Signed-off-by: Richard Asselin <richard.asselin@gmail.com> * 998: Tests to ensure that MemoryDatasets are passed in mocked data catalog Signed-off-by: Richard <CF-FHB-X@users.noreply.github.com> Signed-off-by: Richard Asselin <richard.asselin@gmail.com> * 998: Linting fixes Signed-off-by: Richard <CF-FHB-X@users.noreply.github.com> Signed-off-by: Richard Asselin <richard.asselin@gmail.com> * 998: Changed function according to PR comments Signed-off-by: Richard <CF-FHB-X@users.noreply.github.com> Signed-off-by: Richard Asselin <richard.asselin@gmail.com> * 998: Tests to ensure that MemoryDatasets are passed in mocked data catalog Signed-off-by: Richard Asselin <richard.asselin@gmail.com> * 998: Linting fixes Signed-off-by: Richard Asselin <richard.asselin@gmail.com> Signed-off-by: Richard <CF-FHB-X@users.noreply.github.com> Signed-off-by: Richard Asselin <richard.asselin@gmail.com> * 998: Tweaked release Signed-off-by: Richard Asselin <richard.asselin@gmail.com> * Update RELEASE.md Co-authored-by: ElenaKhaustova <157851531+ElenaKhaustova@users.noreply.github.com> Signed-off-by: Richard <CF-FHB-X@users.noreply.github.com> --------- Signed-off-by: Richard Asselin <richard.asselin@gmail.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> Signed-off-by: ravi_kumar_pilla <ravi_kumar_pilla@mckinsey.com> Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> Signed-off-by: Richard <CF-FHB-X@users.noreply.github.com> Co-authored-by: Ravi Kumar Pilla <ravi_kumar_pilla@mckinsey.com> Co-authored-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com> Co-authored-by: ElenaKhaustova <157851531+ElenaKhaustova@users.noreply.github.com> Co-authored-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PyArrow 19.0.0 broke stuff.
Development notes
This fixes the doctest broken by PyArrow 19.0.0, but not the one broken by Ibis 10.0 (fixed in #1005). Would appreciate if these can be merged separately, so that there's a clearer commit history + we can easily rever the PyArrow pin.
Checklist
jsonschema/kedro-catalog-X.XX.json
if necessaryRELEASE.md
file