Skip to content

Commit

Permalink
fix(datasets): use kwarg for Ibis read_* methods (#1005)
Browse files Browse the repository at this point in the history
* fix(datasets): use kwarg for Ibis `read_*` methods

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* Update RELEASE.md

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

---------

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
  • Loading branch information
deepyaman authored Feb 10, 2025
1 parent 1a5e0fa commit a30c189
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions kedro-datasets/RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
## Bug fixes and other changes

- Fix polars.CSVDataset `save` method on Windows using `utf-8` as default encoding.
- Made `table_name` a keyword argument in the `ibis.FileDataset` implementation to be compatible with Ibis 10.0.

## Breaking Changes

Expand Down
2 changes: 1 addition & 1 deletion kedro-datasets/kedro_datasets/ibis/file_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ def connection(self) -> BaseBackend:
def load(self) -> ir.Table:
load_path = self._get_load_path()
reader = getattr(self.connection, f"read_{self._file_format}")
return reader(load_path, self._table_name, **self._load_args)
return reader(load_path, table_name=self._table_name, **self._load_args)

def save(self, data: ir.Table) -> None:
save_path = self._get_save_path()
Expand Down

0 comments on commit a30c189

Please sign in to comment.