Make swizzled URLSession init method signature match the origin init method to avoid unexpected crash #31
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @kean, first of all, thank you for creating such a cool library!
After the integration using the swizzling approach, we've noticed that our app started to crash occasionally. Apparently, the crash reason was related to the fact that
pust_init
URLSession method signature didn't really match the originalinit
method. The swizzled method haddelegate
defined as non-optional whereas the original method has it defined as optional. Since we're swizzling theinit
method for every instance ofURLSession
created after a call ofURLSession.enableAutomaticRegistration()
it may lead to a crash whennil
passed as adelegate
value.This PR shall also fix #29