Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comply with EIP-5593 #1

Closed
wants to merge 1 commit into from
Closed

comply with EIP-5593 #1

wants to merge 1 commit into from

Conversation

kdenhartog
Copy link
Owner

This limits the places where the provider object will be injected to comply with W3C secure contexts which can be found here https://www.w3.org/TR/secure-contexts/

Explanation

This limits the places where the provider object will be injected to comply with W3C secure contexts which can be found here https://www.w3.org/TR/secure-contexts/

More Information

See EIP-5593

Before

the provider object was able to be injected in non-secure contexts and now it's limited to fewer places where it can be injected.

After

Please be aware there is some limitations here that can break things, so please consider this or offer feedback of how we should address this in the ethereum magicians thread.

Manual Testing Steps

See EIP-5593 which defines where it can be used. I'll be authoring a test suite for it soon as well to make it easier to test compliance.

Pre-Merge Checklist

  • PR template is filled out
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

+ If there are functional changes:

  • Manual testing complete & passed
  • "Extension QA Board" label has been applied

This limits the places where the provider object will be injected to comply with W3C secure contexts which can be found here https://www.w3.org/TR/secure-contexts/
@kdenhartog kdenhartog closed this Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant