Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APIBinding controller, replace inheritFrom with APIBindings #755

Merged
merged 12 commits into from
Mar 25, 2022
Merged

Add APIBinding controller, replace inheritFrom with APIBindings #755

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8bcdb9b
Bump kube
ncdc Mar 8, 2022
d4f5316
server: fix lint error in installApiResourceController
sttts Mar 22, 2022
ccdf804
apibinding: add controller
ncdc Mar 7, 2022
5f83514
apibinding: replace inheritFrom
ncdc Mar 11, 2022
cbaf07e
server: add workspace client for cache-misses on ClusterWorkspace.spe…
sttts Mar 22, 2022
559b7f5
server: use type to identify Organization workspaces, not the lcluster
sttts Mar 23, 2022
f0fd117
dynamic-informer: always assume non-nil workspaceLister
ncdc Mar 11, 2022
7c7defd
e2e: replace api_inheritance test with apibinding test
ncdc Mar 15, 2022
3c80ad0
api/tenancy: remove inheritFrom from ClusterWorkspace
ncdc Mar 15, 2022
a7152ce
server: add API{Export,Binding,ResourceSchema} to system CRDs in univ…
sttts Mar 22, 2022
013538b
server: add TODO to get rid of root informers
sttts Mar 22, 2022
ad73cbf
apis/apibinding: restrict workspace export reference workspace name
sttts Mar 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
server: add TODO to get rid of root informers
  • Loading branch information
@sttts
sttts committed Mar 25, 2022
commit 013538b96056acf64e334857a56e74c96a23f8f7
6 changes: 4 additions & 2 deletions pkg/server/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,12 @@ type Server struct {
syncedCh chan struct{}

kcpSharedInformerFactory kcpexternalversions.SharedInformerFactory
rootKcpSharedInformerFactory kcpexternalversions.SharedInformerFactory
kubeSharedInformerFactory coreexternalversions.SharedInformerFactory
rootKubeSharedInformerFactory coreexternalversions.SharedInformerFactory
apiextensionsSharedInformerFactory apiextensionsexternalversions.SharedInformerFactory

// TODO(sttts): get rid of these. We have wildcard informers already.
rootKcpSharedInformerFactory kcpexternalversions.SharedInformerFactory
rootKubeSharedInformerFactory coreexternalversions.SharedInformerFactory
}

// NewServer creates a new instance of Server which manages the KCP api-server.
Expand Down