-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add checksum in kpm workflow #520
Conversation
I will address the failing CI after this PR (kcl-lang/modules#243) is merged (mostly resolved on its own) and once I receive reviews on the current checksum integration code design. |
f9c06ba
to
8ee4487
Compare
cc @zong-zhe |
Hi @NishantBansal2003 😄 I have tried to test your PR locally, And I think that it needs a feature flag to control the checksum function on and off, because checksum function is a destructive function, it may cause the user's client to not work properly, which is probably the main reason why tests fail in Github Action. You can refer to some of the feature flags implemented here Line 13 in 63bea3a
|
Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
393fed8
to
5a944ea
Compare
Pull Request Test Coverage Report for Build 12010997316Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1. Does this PR affect any open issues?(Y/N) and add issue references:
fix #394
2. What is the scope of this PR (e.g. component or file name):
pkg/client/client.go
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
This PR adds a checksum verification step to the
kpm
workflow to enhance the security and integrity of third-party dependencies. The integration ensures that each package’s checksum is validated during downloading, preventing unauthorized or tampered packages from being incorporated into the project.4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: