-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added trustedSum in checker module #474
Conversation
Pull Request Test Coverage Report for Build 10988739521Details
💛 - Coveralls |
Getting issues with unit tests on Windows while running the script; any help would be appreciated. I will look into it. |
cc: @zong-zhe |
1b1ac7c
to
6701438
Compare
PTAL |
cc @zong-zhe |
6701438
to
c72c964
Compare
c72c964
to
76a82ef
Compare
76a82ef
to
33cc104
Compare
33cc104
to
ecc5e7b
Compare
} | ||
|
||
// WithChecker adds a new Checker to DepChecker. | ||
func WithChecker(checker Checker) DepCheckerOption { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is WithCheckers more appropriate ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the intent was to add checkers to DepChecker
one by one, I named it WithChecker
to emphasise that it includes a single checker at each step. Let me know if you think another name would be more suitable!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try adding a WithCheckers
method, one array at a time.
Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
ecc5e7b
to
dc9a0ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1. Does this PR affect any open issues?(Y/N) and add issue references:
re #394
2. What is the scope of this PR (e.g. component or file name):
kcl-lang/kpm/pkg/checker
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
This PR contains an isolated implementation of the checker module to validate KPM third-party dependencies. The changes have not yet been integrated with KPM third-party dependencies; integration will be done in the future once the checker module design is finalised. The PR includes:
SumChecker
, which validates the dependency checksums in kclPkg.getTrustedSum
, which gives the trusted sum of the dependency from OCI manifest4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: