Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: extra line bothering kcl.mod #436

Merged
merged 2 commits into from
Aug 6, 2024
Merged

bug: extra line bothering kcl.mod #436

merged 2 commits into from
Aug 6, 2024

Conversation

briheet
Copy link
Contributor

@briheet briheet commented Aug 6, 2024

2024-08-06-15:47:51-screenshot

fixes #426

hope so it does not break anything

Signed-off-by: Briheet Singh Yadav <briheetyadav@gmail.com>
@Peefy
Copy link
Contributor

Peefy commented Aug 6, 2024

Hello @briheet

Thanks for the contribution. Could you help fix the CI tests in https://github.com/kcl-lang/kpm/actions/runs/10264863873/job/28400881273?pr=436

Signed-off-by: Briheet Singh Yadav <briheetyadav@gmail.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10265783779

Details

  • 7 of 10 (70.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 40.258%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/package/toml.go 7 10 70.0%
Files with Coverage Reduction New Missed Lines %
pkg/package/toml.go 2 78.79%
Totals Coverage Status
Change from base Build 10263283125: -0.02%
Covered Lines: 3124
Relevant Lines: 7760

💛 - Coveralls

@Peefy Peefy merged commit fbafede into kcl-lang:main Aug 6, 2024
4 of 6 checks passed
@briheet
Copy link
Contributor Author

briheet commented Aug 6, 2024

Hey @Peefy , the toml tests are working fine. But this looked weird to me. Not sure about this maybe test data
2024-08-06-17:05:38-screenshot

Looking forward to contribute :)

@Peefy
Copy link
Contributor

Peefy commented Aug 6, 2024

@briheet
Okay, you can give a try. Thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: extra newline in kcl.mod
3 participants