Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add some position info about import stmt node #974

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Jan 8, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

ast
parse

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

add some position info about import stmt node
from

pub struct ImportStmt {
    pub path: String,
    pub asname: Option<String>,
    ...
}

to

pub struct ImportStmt {
    pub path: Node<String>,
    pub asname: Option<Node<String>>,
    ...
}
  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: he1pa <18012015693@163.com>
@He1pa He1pa changed the title feat: add some position info about import stmt node [wip]feat: add some position info about import stmt node Jan 8, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jan 8, 2024

Pull Request Test Coverage Report for Build 7456278923

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-15.0%) to 72.822%

Totals Coverage Status
Change from base Build 7410481067: -15.0%
Covered Lines: 43404
Relevant Lines: 59603

💛 - Coveralls

@Peefy Peefy added lsp ast parser Issues or PRs related to kcl parser resolver labels Jan 8, 2024
@Peefy Peefy added this to the v0.8.0 Release milestone Jan 8, 2024
@He1pa He1pa changed the title [wip]feat: add some position info about import stmt node feat: add some position info about import stmt node Jan 9, 2024
@He1pa He1pa marked this pull request as ready for review January 9, 2024 03:10
Signed-off-by: he1pa <18012015693@163.com>
@He1pa He1pa force-pushed the enhance_ImportStmt_pos branch from 630bd02 to b94119c Compare January 9, 2024 03:28
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 9a3e0ec into kcl-lang:main Jan 9, 2024
10 of 11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ast lsp parser Issues or PRs related to kcl parser resolver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants