Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix fmt toml. Only allow table after table in root scope #430

Merged
merged 5 commits into from
Jan 8, 2025

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Jan 6, 2025

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: he1pa <18012015693@163.com>
@He1pa He1pa changed the title [wip] fix: fix fmt toml. Only allow table after table in root scope fix: fix fmt toml. Only allow table after table in root scope Jan 6, 2025
@He1pa He1pa marked this pull request as ready for review January 6, 2025 06:46
@He1pa He1pa force-pushed the fix_fmt_toml branch 6 times, most recently from 2a3733f to b8c0f5b Compare January 6, 2025 07:39
Signed-off-by: he1pa <18012015693@163.com>
@coveralls
Copy link

coveralls commented Jan 6, 2025

Pull Request Test Coverage Report for Build 12632106511

Details

  • 12 of 13 (92.31%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 36.455%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/3rdparty/toml/encode.go 12 13 92.31%
Totals Coverage Status
Change from base Build 12631701775: 0.1%
Covered Lines: 5470
Relevant Lines: 15005

💛 - Coveralls

@He1pa He1pa force-pushed the fix_fmt_toml branch 3 times, most recently from f52a593 to 40cbfc0 Compare January 6, 2025 09:17
Signed-off-by: he1pa <18012015693@163.com>
Signed-off-by: he1pa <18012015693@163.com>
Signed-off-by: he1pa <18012015693@163.com>
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zong-zhe zong-zhe merged commit 744add4 into main Jan 8, 2025
19 checks passed
@He1pa He1pa deleted the fix_fmt_toml branch January 8, 2025 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support Go API for GetSchemaTypeMapping
3 participants