Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use dbmen for eggnog #746

Closed
wants to merge 1 commit into from
Closed

use dbmen for eggnog #746

wants to merge 1 commit into from

Conversation

Tianhao-Gu
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.21%. Comparing base (02f0fbe) to head (7e5d658).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #746   +/-   ##
========================================
  Coverage    46.21%   46.21%           
========================================
  Files           78       78           
  Lines         7028     7028           
========================================
  Hits          3248     3248           
  Misses        3780     3780           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCreosote
Copy link
Member

do you think this is causing the slow performance on the worker nodes? If so why wouldn't the login nodes be the same?

@Tianhao-Gu
Copy link
Collaborator Author

Tianhao-Gu commented Jul 11, 2024

do you think this is causing the slow performance on the worker nodes? If so why wouldn't the login nodes be the same?

Still testing the performance. I built the image in login node and test run it in an interactive node. The performance was even worse with this option. With this PR, I just want to build it and run via taskfarmer to see if it improves performance. The performance in general is worse in the worker nodes than in the login node. I used to cut the path to test directly with the login node. Moving forward, I probably will test things in an interactive node to get a better estimation.

@Tianhao-Gu
Copy link
Collaborator Author

But I went over issues on eggnog repo. This option is what the eggnog team suggested in one of the issues.
eggnogdb/eggnog-mapper#80

@MrCreosote
Copy link
Member

ok, sounds like you can test with the pr image so we don't need to merge this, but lmk if I'm wrong

@Tianhao-Gu
Copy link
Collaborator Author

ok, sounds like you can test with the pr image so we don't need to merge this, but lmk if I'm wrong

yea. I can test it with PR image. I will get back to you once I finished testing the image.

@Tianhao-Gu
Copy link
Collaborator Author

ok, sounds like you can test with the pr image so we don't need to merge this, but lmk if I'm wrong

yea. I can test it with PR image. I will get back to you once I finished testing the image.

closing PR. Surpassingly, a single genome takes more than 30 minutes to finish with this option for both 2 nodes and 5 nodes running mode.

@Tianhao-Gu Tianhao-Gu closed this Jul 11, 2024
@Tianhao-Gu Tianhao-Gu deleted the dev_use_dbmen branch July 11, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants