RE2022-336: update tool containers to use threads_per_tool_run #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #711 +/- ##
===========================================
- Coverage 46.25% 46.25% -0.01%
===========================================
Files 78 78
Lines 7017 7018 +1
===========================================
Hits 3246 3246
- Misses 3771 3772 +1 ☔ View full report in Codecov by Sentry. |
MrCreosote
reviewed
Apr 5, 2024
Comment on lines
26
to
28
| - Remove the 'threads' and 'program_threads' parameters | ||
| - and introduce the capability to specify the number of threads per tool run | ||
| - pass job_id to the tool container and remove node_id |
There was a problem hiding this comment.
I don't think you want the hyphen on 2nd line do you? I think that starts a new string
There was a problem hiding this comment.
Not sure if indentation needs to be added or not
MrCreosote
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.