Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RE2022-258: Add genome_attribs histogram endpoint #533

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Conversation

MrCreosote
Copy link
Member

No description provided.

@MrCreosote MrCreosote requested a review from Tianhao-Gu November 6, 2023 20:06
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (36a57d2) 46.73% compared to head (14ced60) 46.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #533      +/-   ##
==========================================
- Coverage   46.73%   46.70%   -0.04%     
==========================================
  Files          73       73              
  Lines        6201     6235      +34     
==========================================
+ Hits         2898     2912      +14     
- Misses       3303     3323      +20     
Files Coverage Δ
src/service/data_products/common_models.py 90.16% <100.00%> (+0.50%) ⬆️
src/service/data_products/genome_attributes.py 32.22% <35.29%> (+0.56%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Tianhao-Gu Tianhao-Gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrCreosote MrCreosote merged commit fe85581 into main Nov 7, 2023
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants