Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RE2022-116: Add selection state update method #190

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Conversation

MrCreosote
Copy link
Member

Also DRY up the 3 state update methods.

Also DRY up the 3 state update methods.
@MrCreosote MrCreosote requested review from dauglyon and Xiangs18 March 20, 2023 19:45
@github-advanced-security
Copy link

You have successfully added a new Trivy configuration .github/workflows/pr_build.yml:build-image. As part of the setup process, we have scanned this repository and found 2 existing alerts. Please check the repository Security tab to see all alerts.

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Patch coverage: 53.33% and project coverage change: +0.13 🎉

Comparison is base (63335ff) 47.66% compared to head (a75012d) 47.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
+ Coverage   47.66%   47.80%   +0.13%     
==========================================
  Files          45       45              
  Lines        3040     3048       +8     
==========================================
+ Hits         1449     1457       +8     
  Misses       1591     1591              
Impacted Files Coverage Δ
src/service/storage_arango.py 25.14% <25.00%> (+0.51%) ⬆️
src/service/routes_collections.py 47.26% <50.00%> (+0.02%) ⬆️
src/service/models.py 92.46% <100.00%> (+0.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MrCreosote
Copy link
Member Author

Ugh, one of those trivy alerts is for httpx, which is pinned to < 19.0 by aioarango, which #163

Copy link
Collaborator

@dauglyon dauglyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all LGTM... but I can't say I am confident in my ability to be confident about AQL. That said, LGTM

@MrCreosote MrCreosote merged commit 12d879d into main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants