Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow more flexible slicing #34

Closed
henrik-dmg opened this issue Mar 6, 2024 · 0 comments · Fixed by #35
Closed

Allow more flexible slicing #34

henrik-dmg opened this issue Mar 6, 2024 · 0 comments · Fixed by #35
Labels
enhancement

Comments

@henrik-dmg
Copy link
Contributor

Based on internal feedback, we should make the following changes:

  • add new config key to deviceData to allow specifying how many images the template should be sliced into
  • remove the validation step that verifies that all screenshots for one template have the same size
@henrik-dmg henrik-dmg mentioned this issue Mar 11, 2024
Merged
henrik-dmg added a commit that referenced this issue Mar 26, 2024
@henrik-dmg
GH-34 Allow more flexible slicing (#35)
88c7bb9 
Signed-off-by: Henrik Panhans <hpanhans@kayak.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-34 Allow more flexible slicing kayak/SwiftFrame
1 participant
@henrik-dmg