Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when stacks goes over allowed max #60

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wozaiha
Copy link
Contributor

@wozaiha wozaiha commented Dec 14, 2024

  1. Removed useless newStackCount.
  2. When the stacks goes over max stacks allowed, refresh it with max stacks instead of directly setting it with newStatus.Stacks.

@wozaiha
Copy link
Contributor Author

wozaiha commented Dec 15, 2024

@CordeliaMist @Glyceri

@Glyceri
Copy link
Collaborator

Glyceri commented Dec 15, 2024

Was it going over the max stack count?

@Glyceri
Copy link
Collaborator

Glyceri commented Dec 15, 2024

Talked about this.
I will add 2 cases that the user can choose.

  1. You add a stack of 2, it doesn't fit so it doesn't apply at all.
  2. You add a stack of 2, it doesn't fit so it only applies the remainder.

This will be an option you can choose.

@CordeliaMist
Copy link
Contributor

image

@wozaiha
Copy link
Contributor Author

wozaiha commented Dec 15, 2024

The game itself seems sets the stacks to the max stacks and then refreash the duration?
Not quite sure.

@Glyceri
Copy link
Collaborator

Glyceri commented Dec 16, 2024

yeah, but thats because in the vanilla game stacks always only go up by 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants