Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Windows platform from plugin.xml to allow install on cordova >9 #444

Merged
merged 2 commits into from
Aug 7, 2019

Conversation

jerodfritz
Copy link
Contributor

As proposed in this thread

@kshabunov
Copy link

@katzer, could you, please, merge this request and release a new version. Cordova CLI 9 fails to install current version, so, I guess, all CIs in the world are failing to build the projects using this plugin now.

@tobika
Copy link

tobika commented Apr 18, 2019

It seems a bit extreme to completely remove the windows platform(maybe people still use it) to fix plugin install under cordova 9?

I'm not under cordova 9 yet but isn't there a different solution? I saw this #441 (comment)

@kshabunov
Copy link

kshabunov commented Apr 18, 2019

It seems a bit extreme to completely remove the windows platform(maybe people still use it) to fix plugin install under cordova 9?

I would agree, but as far as I can see in plugin.xml the whole configuration section related to windows is commented out anyway. I guess that's the reason why install fails: it sees the "engine" line, but there is nothing more.

I'm not under cordova 9 yet but isn't there a different solution? I saw this #441 (comment)

It's not a big problem if you are building the project locally, but I needed to make it work with the Ionic Package service, where install gets the original version. I ended up adding a "before_platform_add" hook that removes the plugin, adds it back (to download it without "install"), and then uses sed to remove the "engine" line from the plugin.xml file.

justincts1975 added a commit to justincts1975/cordova-plugin-background-mode that referenced this pull request Apr 24, 2019
@katzer katzer merged commit 919fbb1 into katzer:master Aug 7, 2019
@katzer
Copy link
Owner

katzer commented Aug 7, 2019

Thanks

raylin01 pushed a commit to truckxinc/cordova-plugin-background-mode that referenced this pull request Jun 7, 2021
katzer#444)

* Remove Windows platcform from plugin.xml to allow install on cordova >9

* @schoenkaft
Fix _alwaysRunsAtForegroundPriority
stefansaenger pushed a commit to vnc-biz/cordova-plugin-background-mode that referenced this pull request Sep 14, 2022
katzer#444)

* Remove Windows platcform from plugin.xml to allow install on cordova >9

* @schoenkaft
Fix _alwaysRunsAtForegroundPriority
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants