Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

vfio: Fix default port assignment with an explicit value in the TOML #5726

Closed
zvonkok opened this issue Jul 21, 2023 · 0 comments · Fixed by #5727
Closed

vfio: Fix default port assignment with an explicit value in the TOML #5726

zvonkok opened this issue Jul 21, 2023 · 0 comments · Fixed by #5727
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.

Comments

@zvonkok
Copy link
Contributor

zvonkok commented Jul 21, 2023

Fix default port assignment with an explicit value in the TOML

It was implicit before and now the runtime will bail out if we did not set it explicitly.
Update the configuration and set it. This will make the intent more clear.

@zvonkok zvonkok added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Jul 21, 2023
zvonkok added a commit to zvonkok/tests that referenced this issue Jul 21, 2023
Fix default port assignment with an explicit value in the TOML
It was implicit before and now the runtime will bail out if we did not set it explicitly.
Update the configuration and set it. This will make the intent more clear.

Fixes: kata-containers#5726

Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
zvonkok added a commit to zvonkok/tests that referenced this issue Jul 21, 2023
Fix default port assignment with an explicit value in the TOML
It was implicit before and now the runtime will bail out if we did not set it explicitly.
Update the configuration and set it. This will make the intent more clear.

Fixes: kata-containers#5726

Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
zvonkok added a commit to zvonkok/tests that referenced this issue Jul 21, 2023
Fix default port assignment with an explicit value in the TOML
It was implicit before and now the runtime will bail out if we did not set it explicitly.
Update the configuration and set it. This will make the intent more clear.

Fixes: kata-containers#5726

Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
zvonkok added a commit to zvonkok/tests that referenced this issue Jul 21, 2023
Fix default port assignment with an explicit value in the TOML
It was implicit before and now the runtime will bail out if we did not set it explicitly.
Update the configuration and set it. This will make the intent more clear.

Fixes: kata-containers#5726

Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
zvonkok added a commit to zvonkok/tests that referenced this issue Jul 21, 2023
Fix default port assignment with an explicit value in the TOML
It was implicit before and now the runtime will bail out if we did not set it explicitly.
Update the configuration and set it. This will make the intent more clear.

Fixes: kata-containers#5726

Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
zvonkok added a commit to zvonkok/tests that referenced this issue Jul 23, 2023
Fix default port assignment with an explicit value in the TOML
It was implicit before and now the runtime will bail out if we did not set it explicitly.
Update the configuration and set it. This will make the intent more clear.

Fixes: kata-containers#5726

Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
zvonkok added a commit to zvonkok/tests that referenced this issue Jul 23, 2023
Fix default port assignment with an explicit value in the TOML
It was implicit before and now the runtime will bail out if we did not set it explicitly.
Update the configuration and set it. This will make the intent more clear.

Fixes: kata-containers#5726

Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
zvonkok added a commit to zvonkok/tests that referenced this issue Jul 23, 2023
Fix default port assignment with an explicit value in the TOML
It was implicit before and now the runtime will bail out if we did not set it explicitly.
Update the configuration and set it. This will make the intent more clear.

Fixes: kata-containers#5726

Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
zvonkok added a commit to zvonkok/tests that referenced this issue Jul 23, 2023
Fix default port assignment with an explicit value in the TOML
It was implicit before and now the runtime will bail out if we did not set it explicitly.
Update the configuration and set it. This will make the intent more clear.

Fixes: kata-containers#5726

Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
zvonkok added a commit to zvonkok/tests that referenced this issue Jul 23, 2023
Fix default port assignment with an explicit value in the TOML
It was implicit before and now the runtime will bail out if we did not set it explicitly.
Update the configuration and set it. This will make the intent more clear.

Fixes: kata-containers#5726

Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
zvonkok added a commit to zvonkok/tests that referenced this issue Jul 23, 2023
Fix default port assignment with an explicit value in the TOML
It was implicit before and now the runtime will bail out if we did not set it explicitly.
Update the configuration and set it. This will make the intent more clear.

Fixes: kata-containers#5726

Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
zvonkok added a commit to zvonkok/tests that referenced this issue Jul 23, 2023
Fix default port assignment with an explicit value in the TOML
It was implicit before and now the runtime will bail out if we did not set it explicitly.
Update the configuration and set it. This will make the intent more clear.

Fixes: kata-containers#5726

Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
zvonkok added a commit to zvonkok/tests that referenced this issue Jul 24, 2023
Fix default port assignment with an explicit value in the TOML
It was implicit before and now the runtime will bail out if we did not set it explicitly.
Update the configuration and set it. This will make the intent more clear.

Fixes: kata-containers#5726

Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
zvonkok added a commit to zvonkok/tests that referenced this issue Jul 25, 2023
Fix default port assignment with an explicit value in the TOML
It was implicit before and now the runtime will bail out if we did not set it explicitly.
Update the configuration and set it. This will make the intent more clear.

Fixes: kata-containers#5726

Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
zvonkok added a commit to zvonkok/tests that referenced this issue Jul 25, 2023
Fix default port assignment with an explicit value in the TOML
It was implicit before and now the runtime will bail out if we did not set it explicitly.
Update the configuration and set it. This will make the intent more clear.

Fixes: kata-containers#5726

Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
zvonkok added a commit to zvonkok/tests that referenced this issue Jul 25, 2023
Fix default port assignment with an explicit value in the TOML
It was implicit before and now the runtime will bail out if we did not set it explicitly.
Update the configuration and set it. This will make the intent more clear.

Fixes: kata-containers#5726

Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant