Add support for script pre-processing via shebang/#! #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request adds support for generic pre-preprocessing of JavaScript through the use of a shebang at the top of your Phoenix JS config. This also adds support for ~/.phoenix[-debug].js being a symlink **Example:** ```javascript \#!/usr/bin/env babel // ... Custom Phoenix JS ```
|
@shayne Thank you ever so much for this great idea and pull request! I tested it out and made some small alterations to make it more robust. It is now merged. |
| *errorMessage = [[NSString alloc] initWithData:errorData encoding:NSUTF8StringEncoding]; | ||
| } | ||
|
|
||
| /* Read past the shebang line to prevent syntax error */ |
There was a problem hiding this comment.
See #46 please explain which preprocessors leave the shebang in their output? None I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for generic pre-preprocessing of
JavaScript through the use of a shebang at the top of your Phoenix JS
config.
This also adds support for ~/.phoenix[-debug].js being a symlink
Example:
#!/usr/bin/env babel // ... Custom Phoenix JS