Fix inability to use symlinked config with relative includes #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7895286 to
8b2f6bf
Compare
| @@ -136,10 +136,17 @@ - (void) setupAPI { | |||
| self.context[@"Mouse"] = [PHMouse class]; | |||
| self.context[@"App"] = [PHApp class]; | |||
| self.context[@"Window"] = [PHWindow class]; | |||
|
|
|||
8b2f6bf to
51a2285
Compare
|
Tested with a require('./libs/test.js');
require('~/root-test.js'); |
My Phoenix config is symlinked to `~/.phoenix.js` from my dotfiles
directory. This PR adds support for relative requires whether or not
you're using a symlinked config file, it also maintains support for
absoltue path includes (e.g. `require('~/jslibs/some-file.js')`).
51a2285 to
a72469b
Compare
|
@shayne Now that is a clean fix! Sorry for the wait. Indeed |
kasper
added a commit
that referenced
this pull request
Nov 17, 2015
Fix inability to use symlinked configuration with relative includes
kasper
added a commit
that referenced
this pull request
Nov 17, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My Phoenix config is symlinked to
~/.phoenix.jsfrom my dotfilesdirectory. This PR adds support for relative requires whether or not
you're using a symlinked config file, it also maintains support for
absoltue path includes (e.g.
require('~/jslibs/some-file.js')).