Make app.launch() faster by introducing an option #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, definitely feels more responsive than doing launch + focus 👍. |
mafredri
reviewed
May 1, 2018
| @@ -613,6 +613,10 @@ end | |||
|
|
|||
| - `force` (boolean): if set `true` force terminates the app | |||
|
|
|||
| ### Launch Optionals | |||
There was a problem hiding this comment.
The description for launch(String appName) above should also be updated (sorry, GitHub doesn't let me comment there since it wasn't changed).
app.launch() now takes an extra options parameter. If `focus` is set to true, then OC code will use NSWorkspaceLaunchDefault instead of NSWorkspaceLaunchWithoutActivation to call launchApplicationAtURL. The launched app will auto focus, and the speed will be noticeably faster.
|
@kasper could you please take a look at merge this and ship 2.6.2? 💯 |
|
Thanks! |
|
@txchen Sorry for the wait. Released! |
|
Thanks @kasper ! Now I can switch back to official release, yeah! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
app.launch() now takes an extra options parameter. If
focusis set totrue, then OC code will use NSWorkspaceLaunchDefault instead of
NSWorkspaceLaunchWithoutActivation to call launchApplicationAtURL. The
launched app will auto focus, and the speed will be noticeably faster.