Add timestamps to IBD progress #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protocol/flows/src/v5/ibd/flow.rs
Outdated
| @@ -538,9 +546,10 @@ staging selected tip ({}) is too small or negative. Aborting IBD...", | |||
| &mut self, | |||
| consensus: &ConsensusProxy, | |||
| chunk: &[Hash], | |||
| ) -> Result<(Vec<BlockValidationFuture>, u64), ProtocolError> { | |||
| ) -> Result<(Vec<BlockValidationFuture>, u64, u64), ProtocolError> { | |||
There was a problem hiding this comment.
what about using type alias or wrapping to struct with fields to make function signature clear?
what is u64 and u64? that's not clear without reading function body
d9f82e6 to
d5bab35
Compare
michaelsutton
previously approved these changes
Jan 7, 2024
michaelsutton
approved these changes
Jan 7, 2024
KashProtocol
pushed a commit
to Kash-Protocol/rusty-kash
that referenced
this pull request
Jan 8, 2024
* Add timestamps to IBD progress * Add timezone * Address review comments * Change error message
D-Stacks
pushed a commit
to D-Stacks/rusty-kaspa
that referenced
this pull request
Jan 8, 2024
* Add timestamps to IBD progress * Add timezone * Address review comments * Change error message
KashProtocol
pushed a commit
to Kash-Protocol/rusty-kash
that referenced
this pull request
Jan 8, 2024
* Add timestamps to IBD progress * Add timezone * Address review comments * Change error message
KashProtocol
pushed a commit
to Kash-Protocol/rusty-kash
that referenced
this pull request
Jan 9, 2024
* Add timestamps to IBD progress * Add timezone * Address review comments * Change error message
D-Stacks
pushed a commit
to D-Stacks/rusty-kaspa
that referenced
this pull request
Jan 23, 2024
* Add timestamps to IBD progress * Add timezone * Address review comments * Change error message
smartgoo
pushed a commit
to smartgoo/rusty-kaspa
that referenced
this pull request
Jun 18, 2024
* Add timestamps to IBD progress * Add timezone * Address review comments * Change error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.