Fix Rust 1.75 warnings #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests --benches --features devnet-prealloc` note that all these `pub use` were not really exposed publicly on the crate level
aspect
approved these changes
Dec 31, 2023
KashProtocol
pushed a commit
to Kash-Protocol/rusty-kash
that referenced
this pull request
Jan 5, 2024
* fix new unused imports warns by running `cargo clippy --fix --all --tests --benches --features devnet-prealloc` note that all these `pub use` were not really exposed publicly on the crate level * fix `variant name ends with the enum's name` warnings
KashProtocol
pushed a commit
to Kash-Protocol/rusty-kash
that referenced
this pull request
Jan 8, 2024
* fix new unused imports warns by running `cargo clippy --fix --all --tests --benches --features devnet-prealloc` note that all these `pub use` were not really exposed publicly on the crate level * fix `variant name ends with the enum's name` warnings
KashProtocol
pushed a commit
to Kash-Protocol/rusty-kash
that referenced
this pull request
Jan 9, 2024
* fix new unused imports warns by running `cargo clippy --fix --all --tests --benches --features devnet-prealloc` note that all these `pub use` were not really exposed publicly on the crate level * fix `variant name ends with the enum's name` warnings
D-Stacks
pushed a commit
to D-Stacks/rusty-kaspa
that referenced
this pull request
Jan 23, 2024
* fix new unused imports warns by running `cargo clippy --fix --all --tests --benches --features devnet-prealloc` note that all these `pub use` were not really exposed publicly on the crate level * fix `variant name ends with the enum's name` warnings
smartgoo
pushed a commit
to smartgoo/rusty-kaspa
that referenced
this pull request
Jun 18, 2024
* fix new unused imports warns by running `cargo clippy --fix --all --tests --benches --features devnet-prealloc` note that all these `pub use` were not really exposed publicly on the crate level * fix `variant name ends with the enum's name` warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually
pub useimports should not be a warning as they are intended for public usage, however the compiler is right about all these: they are all not actually exposed on the crate level (nor used within the crate). See for reference rust-lang/rust#117120 (comment)