Fix disappearing form pressing enter. #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix immediately disappearing form in inline mode, when pressing enter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix immediately disappearing form in inline mode, when pressing enter.
Scope
This pull request includes a
Related Issues
#128
Further information
A form will use the first button it encounters as the submit button, when it doesn't contain a type or is of the type 'submit'. Both the reset and the submit button have the type 'button'. The close button doesn't have a type. When enter is pressed, it will trigger the submit event. Which will trigger the close button. Which will, as coded in JavaScript, close the form.
See also: http://stackoverflow.com/questions/290215/difference-between-input-type-button-and-input-type-submit