improve lua vm executing with pool

[ikaven1024]

Signed-off-by: yingjinhui yingjinhui@didiglobal.com

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
At present, we create a new Lua vm to run script for every calling. This pr create vm once, before running script, get vm from pool, reducing the cost of vm creating.

I test it with a demo, calling the script every 10ms:

const script = `
function GetReplicas(obj)
	return 0, {}
end`

func main() {
	vm := luavm.New(false, 10)
	for range time.Tick(time.Millisecond * 10) {
		_, _, err := vm.GetReplicas(&unstructured.Unstructured{}, script)
		if err != nil {
			fmt.Println(err)
			os.Exit(1)
		}
	}
}

and implements GetReplicas in two ways:

• without pool : run in luavm1 pod
• with pool: run in luavm2 pod

Even in luavm2 cost little more memory(48M v.s. 36M), but has much less in CPU (0.03 v.s. 0.1)

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[XiShanYongYe-Chang]

/assign

[XiShanYongYe-Chang]

Is the increase in memory consumption related to the pool size of the lua VM?

[XiShanYongYe-Chang]

Thanks~ Can we use this lua VM in the karmadactl interpret command?
/lgtm
/cc @RainbowMango @jameszhangyukun

[karmada-bot]

@XiShanYongYe-Chang: GitHub didn't allow me to request PR reviews from the following users: jameszhangyukun.

Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Thanks~ Can we use this lua VM in the karmadactl interpret command?
/lgtm
/cc @RainbowMango @jameszhangyukun

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[RainbowMango]

Looks great!

Can we use this lua VM in the karmadactl interpret command?

Does #2824 depend on it?

[ikaven1024]

Is the increase in memory consumption related to the pool size of the lua VM?

Yes. The pool size shall be balanced between memory and cpu cost. But now I have no sufficient evidences which is best.

karmada/pkg/resourceinterpreter/configurableinterpreter/configurable.go

Lines 28 to 29 in 6feeb91

	// TODO: set an appropriate pool size.
	luaVM: luavm.New(false, 10),

[ikaven1024]

Looks great!

Can we use this lua VM in the karmadactl interpret command?

Does #2824 depend on it?

In interpret command, we only call vm once, it's no need to use VM pool. So these 2 PRs has no relations

[XiShanYongYe-Chang]

/assign @RainbowMango

[RainbowMango]

NewInstance is not going to create a new lua VM.

[ikaven1024]

updated

[RainbowMango]

/lgtm
/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment