Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt namespace UI #193

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Conversation

warjiang
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:

  • set width for better display according to language
  • use popconfirm, force user double check before delete namespace

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

- set dynamic label width  according to language
- add popconfirm when delete namepace

Signed-off-by: warjiang <1096409085@qq.com>
@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 12, 2025
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 12, 2025
Signed-off-by: warjiang <1096409085@qq.com>
@warjiang warjiang force-pushed the feat/opt-namespace-ui branch from fc3cfc2 to e86947e Compare February 12, 2025 16:37
@RainbowMango RainbowMango added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 13, 2025
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2025
@karmada-bot karmada-bot merged commit f787eed into karmada-io:main Feb 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants